Updated dependency to TestContainer to 2.0#473
Merged
smcvb merged 3 commits intoconnector-2025.2.xfrom Jan 22, 2026
Merged
Conversation
Configured maven build with Mockito agent to support JDK21+ where dynamic class definitions aren't allowed by default anymore. Removed some old references to org.junit.Assert, which is deprecated and no longer available after the upgrade. TestContainers update is (apparently) required for compatibility with new Docker APIs.
MGathier
approved these changes
Jan 13, 2026
smcvb
requested changes
Jan 13, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
Changes seem fine to me, the build disagrees though. Hence why I am requesting changes.
The DcbEndToEndTest printed all container logs to the test logging. While useful for debugging in certain cases, it is excessive as part of a regular build
smcvb
reviewed
Jan 21, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
Removing the logger seems like a smart move 😅
This seems to revert a change in default settings in a new javadoc plugin version.
smcvb
approved these changes
Jan 22, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
My concerns have been addressed, hence I'm approving this pull request.
Furthermore, noted only the JDK17 build right now, on a test that's sometimes flaky. Kicked off the build again to see if it runs this time.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configured maven build with Mockito agent to support JDK21+ where dynamic class definitions aren't allowed by default anymore.
Removed some old references to org.junit.Assert, which is deprecated and no longer available after the upgrade.
TestContainers update is (apparently) required for compatibility with new Docker APIs.