Adjust Subscribable Eventsource API and move reference documentation for persistent streams#4616
Draft
hatzlj wants to merge 2 commits into
Draft
Adjust Subscribable Eventsource API and move reference documentation for persistent streams#4616hatzlj wants to merge 2 commits into
hatzlj wants to merge 2 commits into
Conversation
hatzlj
added
Priority 1: Must
hatzlj
changed the title
In the course of reintroducing the persistent streams feature to Framework 5, we move the documentation to the Axoniq Framework repository.
…batch consumer The javadoc of the `org.axonframework.messaging.core.SubscribableEventSource.subscribe` function clearly states that the processing context for the batch consumer bi-function may be null. We should reflect this with the appropriate `@Nullable` annotation.
hatzlj
force-pushed
the
documentation/persistent-streams
branch
from
c82a000 to
b9e93c3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the course of reintroducing the persistent streams feature to Framework 5, we
SubscribableEventSourceto reflect the fact that the processing context supplied to the event batch consumer bi-function might be null (already stated as such in the javadoc and handled as such in the places where it is used)Set to draft until we have the implementation in Axoniq Framework ready