feat(FocusedWindow): Improve content width calculation and add size options#2444
Open
lichie567 wants to merge 2 commits into
Open
feat(FocusedWindow): Improve content width calculation and add size options#2444lichie567 wants to merge 2 commits into
lichie567 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two main changes in this PR:
RowLayoutinstead ofRowfor improved content width calculation.With this change, "Compact Mode" no longer has any affect on the widget's actual size, but only hides the app name prefix.
I've chosen the following sizes for each option:
Small -> Same size as the previous "Compact Mode" widget
Medium -> Same size as the previous normal widget
Large -> roughly 40% bigger than the previous normal widget
Largest -> roughly 80% bigger than the previous normal widget
I'm open to changing these sizes if you have any feedback.