feat: implement interactive microphone volume OSD and IPC controls#2406
Open
hthienloc wants to merge 2 commits into
Open
feat: implement interactive microphone volume OSD and IPC controls#2406hthienloc wants to merge 2 commits into
hthienloc wants to merge 2 commits into
Conversation
hthienloc
force-pushed
the
feat/mic-volume-system
branch
from
c273d6c to
c348c8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a dedicated microphone volume management system, moving beyond the simple mute toggle to provide full volume control and visual feedback.
Key Changes
micIPC Target: Added a specializedmictarget inDMSShellIPC.qmlsupportingsetvolume,increment,decrement,mute, andstatus.MicVolumeOSD.qmlfeaturing a reactive slider and visual mute indicators. Users can now adjust microphone levels directly from the OSD.osdMicVolumeEnabledtoSettingsData.qmlto allow users to toggle microphone OSD visibility.KeybindActions.jsto utilize the new IPC system.audiotarget are now marked as deprecated.Why
Users currently lack visual feedback when adjusting or muting their microphone. This implementation brings the microphone experience in line with the system volume experience.
How Tested
dms ipc mic <cmd>.osdMicVolumeEnabledcorrectly gates the OSD visibility.Addresses #2388