support QT_QPA_PLATFORMTHEME=kde#2321
Conversation
dms already supports Kcolorscheme. QT_QPA_PLATFORMTHEME=kde support allows you to dynamically switch light and dark mode of QT apps without needing a restart.
| syncColorScheme(opts.Mode) | ||
| } | ||
|
|
||
| applyKDEColorScheme(opts.Mode) |
There was a problem hiding this comment.
The GTK version is gated on whether or not the user is actually using the DMS colors or not, I think we need something equivalent. Like we wouldn't wanna apply the scheme if they're using something besides DankMatugen
There was a problem hiding this comment.
But shouldn't that be the kde color sync? Otherwise what's the point in syncing kde colors ?
There was a problem hiding this comment.
The matugen is running unconditionally on theme changes I mean. If someone has Breeze configured won't it change it to DankMatugen even if they didn't want that? Some users want dms without all the themes it provides
There was a problem hiding this comment.
Well the color scheme works fine with Breeze that's specifically what Kcolorscheme is designed for. But maybe I should check if QT_QPA_PLATFORMTHEME is set to kde with QT_STYLE_OVERRIDE Breeze. I imagine it might cause problems with kvantum. But the people that use kvantum seem to set QT_QPA_PLATFORMTHEME to qt6ct
There was a problem hiding this comment.
I guess I mean color scheme, if they are using a different color scheme like Breeze Dark and they want to keep it, this path will unconditionally change it to DankMatugen. So we should add a gate for current color scheme, if it's a DMS one then we can flip it to dark/light
3 participants
dms already supports Kcolorscheme. QT_QPA_PLATFORMTHEME=kde support allows you to dynamically switch light and dark mode of QT apps without needing a restart.