Refocus all skills on wall-clock build time as primary metric#1
Merged
Conversation
…tric User feedback showed the skills were over-indexing on cumulative task time (which Xcode parallelizes) and presenting it as build-time savings. This led to many source-level fixes that reduced compiler workload without actually reducing how long the developer waits. Key changes: - AGENTS.md: wall-clock first principle inherited by all skills - Orchestrator: blocking-vs-parallel heuristics, impact language templates, wall-clock-first final report - Report script/template: timing-table disclaimers, wait-time impact field, plain-language verification - Compilation analyzer: parallel workload labeling when not on critical path - Project/SPM analyzers: wall-clock qualifier on prioritization tiers - Fixer: wall-clock delta leads reporting, honest language when task metrics improve but wait time does not - Benchmark artifacts: documents wall-clock vs cumulative distinction - Recommendation format: new wait_time_impact required field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdContext
User feedback showed the skills were great at diagnosing issues (SwiftUI hotspots, build settings, SPM pinning) but over-promised impact by communicating in cumulative task time. This led to many source-level fixes that reduced compiler workload without actually reducing build wait time -- in one case adding 0.1s to the build despite large hotspot reductions.
Files changed (10)
AGENTS.md-- wall-clock-first principleskills/xcode-build-orchestrator/SKILL.md-- prioritization rewrite, impact language, final reportskills/xcode-build-orchestrator/references/orchestration-report-template.md-- timing disclaimers, wait-time impact examplesscripts/generate_optimization_report.py-- timing-table disclaimers, wait_time_impact field renderingskills/xcode-compilation-analyzer/SKILL.md-- parallel workload labelingskills/xcode-project-analyzer/references/project-audit-checks.md-- wall-clock qualifierskills/spm-build-analysis/references/spm-analysis-checks.md-- wall-clock qualifierskills/xcode-build-fixer/SKILL.md-- wall-clock-first reportingreferences/benchmark-artifacts.md-- wall-clock vs cumulative distinctionreferences/recommendation-format.md-- new wait_time_impact fieldTest plan