Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 8, 2017

WPCS fixes via PHPCS.

@stodorovic
Copy link

It's sample file for wp-cache-config.php. Function wp_cache_replace_line parses line by line and it isn't possible to use few lines (eg. Array( ...).
So, I think that's better to we ignore this file now. Maybe we can improve it in the future, but it could make side effects with current code.

@stodorovic
Copy link

I'm not sure because wp_cache_setting will override these changes. I'm just looking and I think that we need to improve wp_cache_setting, wp_cache_replace_line, wp_cache_update_rejected_pages and probably something more.
I'd like to improve regular expression https://github.com/Automattic/wp-super-cache/blob/master/wp-cache-phase2.php#L1086 before we continue with this file.

@stodorovic
Copy link

I just created first version - PR #487. It works by my quick testing. Please review it and test it. I see more places which should be improved, current code isn't perfect, but good for start. I'll continue tomorrow if I find free time.

@ghost ghost closed this Dec 12, 2017
@ghost ghost deleted the PHPCS_fix/wp-cache-config-sample.php branch December 12, 2017 20:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant