Prototype: replace WpErrorCode fallback with WpErrorCodeValue record#1365
Draft
oguzkocer wants to merge 2 commits into
Draft
Prototype: replace WpErrorCode fallback with WpErrorCodeValue record#1365oguzkocer wants to merge 2 commits into
WpErrorCode fallback with WpErrorCodeValue record#1365oguzkocer wants to merge 2 commits into
Conversation
Replace the `CustomError(String)` fallback variant in `WpErrorCode` with a new `WpErrorCodeValue` record that separates the parsed enum from the raw API string: - `value: Option<WpErrorCode>` — `Some` for known variants, `None` for unknown - `raw: String` — always the original string from the API This makes adding new `WpErrorCode` variants forward-compatible: client code checking the `raw` string continues to work after a variant is promoted, and the enum stays a real enum with full match support. Also changes `WpErrorCode` from `uniffi::Error` to `uniffi::Enum` since it was never returned as an error directly — always embedded as a field. Helper methods on `WpErrorCodeValue`: `is_code()`, `is_raw()`, `is_any_code()`.
Collaborator
|
Every PR should add an entry under the
If the change genuinely has no user-visible impact (e.g. CI-only tweaks, internal refactors), add a short entry under |
Collaborator
XCFramework BuildThis PR's XCFramework is available for testing. Add to your .package(url: "https://github.com/automattic/wordpress-rs", branch: "pr-build/1365")Built from c88cca7 |
`retrieveWithEditContext` expects a `PostType`, not a raw string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the
CustomError(String)fallback variant inWpErrorCodewith a newWpErrorCodeValuerecord that separates the parsed enum from the raw API string:value: Option<WpErrorCode>—Somefor known variants,Nonefor unknownraw: String— always the original string from the APIThis makes adding new
WpErrorCodevariants forward-compatible: client code checking therawstring continues to work after a variant is promoted, and the enum stays a real enum with full match support.Also changes
WpErrorCodefromuniffi::Errortouniffi::Enumsince it was never returned as an error directly — always embedded as a field.Helper methods on
WpErrorCodeValue:is_code(),is_raw(),is_any_code().Changelog
CHANGELOG.mdunder## [Unreleased], using the Keep a Changelog categories (Added,Changed,Deprecated,Removed,Fixed,Security). Prefix breaking changes with**BREAKING:**.