Prototype: wrap MediaType in a UniFFI object to prevent fallback variant breakage#1364
Draft
oguzkocer wants to merge 1 commit into
Draft
Prototype: wrap MediaType in a UniFFI object to prevent fallback variant breakage#1364oguzkocer wants to merge 1 commit into
MediaType in a UniFFI object to prevent fallback variant breakage#1364oguzkocer wants to merge 1 commit into
Conversation
…riant breakage When a new named variant is added to an enum with a fallback (e.g. `Custom(String)`), Kotlin/Swift code checking `is CustomException` silently stops matching. This wraps `MediaType` in a `MediaTypeWrapper` UniFFI object so clients must use `isMediaType()` for comparison, which normalizes through the string representation and is resilient to variant promotion.
Collaborator
|
Every PR should add an entry under the
If the change genuinely has no user-visible impact (e.g. CI-only tweaks, internal refactors), add a short entry under |
Collaborator
XCFramework BuildThis PR's XCFramework is available for testing. Add to your .package(url: "https://github.com/automattic/wordpress-rs", branch: "pr-build/1364")Built from 8ef9173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a new named variant is added to an enum with a fallback (e.g.
Custom(String)), Kotlin/Swift code checkingis CustomExceptionsilently stops matching. This wrapsMediaTypein aMediaTypeWrapperUniFFI object so clients must useisMediaType()for comparison, which normalizes through the string representation and is resilient to variant promotion.