-
Notifications
You must be signed in to change notification settings - Fork 86
Add FEP-7aa9 consent endpoint for featured collections #3277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pfefferle
wants to merge
21
commits into
trunk
Choose a base branch
from
add/featured-collections-consent
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
49743f6
Gitignore docs/superpowers/ for local-only superpowers artifacts.
pfefferle 263f7ce
Register FEP-7aa9 vocabulary and FeatureRequest activity type.
pfefferle dc8e041
Use durable IRI for FEP-7aa9 reference.
pfefferle b001144
Add Feature_Authorization extended object for FEP-7aa9 stamps.
pfefferle 51bf5ea
Strengthen Feature_Authorization context test, document standalone sh…
pfefferle adb8c94
Register activitypub_default_feature_policy option.
pfefferle 4a7bb8f
Add settings UI for default feature collection policy.
pfefferle 87db0b2
Add Feature_Request handler skeleton with validation and blocked-path.
pfefferle bd9301d
Strengthen Feature_Request handler tests after code review.
pfefferle 6ea8cd8
Implement FeatureRequest policy branch with idempotent Accept stamps.
pfefferle 8573370
Register Feature_Request handler during plugin bootstrap.
pfefferle c9bbd8c
Advertise interactionPolicy.canFeature on actor JSON.
pfefferle 3bdc1c1
Resolve ?actor=ID&stamp=ID URLs to FeatureAuthorization JSON.
pfefferle cf57b9f
Add changelog entry for feature collections consent.
pfefferle 937a920
Fix actor stamp URL routing collision after final review.
pfefferle bd1dfc0
Address final review on the consent layer.
pfefferle c992f94
Address review follow-ups: tests + router comment.
pfefferle 5a20a43
Address Copilot review and fix Test_Outbox CI failure.
pfefferle bb72aef
Merge branch 'trunk' into add/featured-collections-consent
pfefferle 283c95d
Merge branch 'trunk' into add/featured-collections-consent
pfefferle cf167f2
Merge branch 'trunk' into add/featured-collections-consent
pfefferle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| Add an opt-in setting to consent to inclusion in Starter Kits (also called Starter Packs or Featured Collections). Off by default. Find it under Settings, ActivityPub, Activities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
includes/activity/extended-object/class-feature-authorization.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| <?php | ||
| /** | ||
| * Feature_Authorization is an implementation of the FeatureAuthorization activity type, | ||
| * as defined in FEP-7aa9 (https://w3id.org/fep/7aa9). | ||
| * | ||
| * This class represents a FeatureAuthorization activity for ActivityPub implementations. | ||
| * | ||
| * @package Activitypub | ||
| */ | ||
|
|
||
| namespace Activitypub\Activity\Extended_Object; | ||
|
|
||
| use Activitypub\Activity\Base_Object; | ||
|
|
||
| /** | ||
| * Class representing a FeatureAuthorization activity. | ||
| * | ||
| * @see https://w3id.org/fep/7aa9 | ||
| * | ||
| * @since unreleased | ||
| * | ||
| * @method Base_Object|string|array|null get_interacting_object() Gets the interacting object property of the object. | ||
| * @method Base_Object|string|array|null get_interaction_target() Gets the interaction target property of the object. | ||
| * | ||
| * @method Feature_Authorization set_interacting_object( string|array|Base_Object|null $data ) Sets the interacting object property of the object. | ||
| * @method Feature_Authorization set_interaction_target( string|array|Base_Object|null $data ) Sets the interaction target property of the object. | ||
| */ | ||
| class Feature_Authorization extends Base_Object { | ||
| /** | ||
| * The JSON-LD context for the object. | ||
| * | ||
| * Intentionally minimal: stamps are always served standalone at their own | ||
| * URL, so we ship only the vocabulary the stamp document itself uses. | ||
| * Mirrors the Quote_Authorization (FEP-044f) approach. | ||
| * | ||
| * @var array | ||
| */ | ||
| const JSON_LD_CONTEXT = array( | ||
| 'https://www.w3.org/ns/activitystreams', | ||
| array( | ||
| 'FeatureAuthorization' => 'https://w3id.org/fep/7aa9#FeatureAuthorization', | ||
| 'gts' => 'https://gotosocial.org/ns#', | ||
| 'interactingObject' => array( | ||
| '@id' => 'gts:interactingObject', | ||
| '@type' => '@id', | ||
| ), | ||
| 'interactionTarget' => array( | ||
| '@id' => 'gts:interactionTarget', | ||
| '@type' => '@id', | ||
| ), | ||
| ), | ||
| ); | ||
|
|
||
| /** | ||
| * The type of the object. | ||
| * | ||
| * @var string | ||
| */ | ||
| protected $type = 'FeatureAuthorization'; | ||
|
|
||
| /** | ||
| * The object that is being interacted with. | ||
| * | ||
| * @var Base_Object|string|array|null | ||
| */ | ||
| protected $interacting_object; | ||
|
|
||
| /** | ||
| * The target of the interaction. | ||
| * | ||
| * @var Base_Object|string|array|null | ||
| */ | ||
| protected $interaction_target; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.