Add Fediverse view to admin comments list #2663

pfefferle · 2025-12-18T10:22:09Z

Depends on #2662

Proposed changes:

Add a "Fediverse" link to the WordPress admin comments page (alongside All, Mine, Pending, Approved, Spam, Trash)
Allow users to view and manage comments from hidden post types (like ap_post)
Use comment_status=federated parameter to integrate with WordPress's native comment status system
Display comment count in the Fediverse view

Other information:

Have you written new tests for your changes, if applicable?

Testing instructions:

Go to Comments in the WordPress admin
Verify a "Fediverse" link appears alongside other status links
Click the Fediverse link to see comments from federated posts
Verify the count shows correctly
Verify "Fediverse" is highlighted when viewing that filter

Changelog entry

Automatically create a changelog entry from the details below.

Changelog Entry Details

Significance

Patch
Minor
Major

Type

Added - for new features
Changed - for changes in existing functionality
Deprecated - for soon-to-be removed features
Removed - for now removed features
Fixed - for any bug fixes
Security - in case of vulnerabilities

Message

Add Fediverse view to admin comments list.

This method returns post types whose comments should be hidden in the WordPress admin. Used for filtering comment queries and auto-approving comments on non-public post types like ap_post.

This method returns post types whose comments should be hidden in the WordPress admin comments list.

Introduces a 'Fediverse' filter in the admin comment views, allowing users to view comments from hidden post types such as 'ap_post'. Updates comment query logic to support this new view and display only relevant comments when selected.

Adds a comment count badge to the 'Fediverse' filter in the admin comments view and updates the query logic to better handle post type filtering for federated comments.

Replaces a generic post type check with a specific comparison to self::hide_for() in the admin comment query logic, ensuring only comments from the intended hidden post type are shown in the Fediverse view.

Copilot

Pull request overview

This PR adds a "Fediverse" view to the WordPress admin comments list, allowing administrators to view and manage comments from hidden post types (specifically ap_post - ActivityPub federated posts). The implementation introduces a new filter mechanism to control which post types should have their comments hidden from the main admin view.

Key Changes

Introduces a hide_for() method in the Comment class that returns post types whose comments should be hidden by default, with a filterable implementation
Adds a "Fediverse" link to the admin comments page views with a comment count badge
Modifies comment query logic to either exclude or show only hidden post type comments based on the comment_status=federated parameter

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File	Description
includes/class-comment.php	Adds `hide_for()` method to define hidden post types and updates `comment_query()` and `pre_comment_approved()` to use this new abstraction
includes/wp-admin/class-admin.php	Implements `comment_views()` to add the Fediverse filter link with comment count to the admin UI
tests/phpunit/tests/includes/class-test-comment.php	Updates existing tests to reflect new behavior and adds comprehensive test coverage for the `hide_for()` filter mechanism
.github/changelog/add-get-non-public-post-types	Adds changelog entry for the feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-18T10:30:28Z

.github/changelog/add-get-non-public-post-types

+Significance: minor
+Type: added
+
+Hide comments from specific post types in the WordPress admin comments list.


The changelog message "Hide comments from specific post types in the WordPress admin comments list" doesn't accurately reflect the feature being added. The PR actually adds a Fediverse view to show (not hide) comments from specific post types. Consider updating to something like "Add Fediverse view to admin comments list to show comments from federated posts" to better match the actual functionality.

Suggested change

Hide comments from specific post types in the WordPress admin comments list.

Add Fediverse view to admin comments list to show comments from federated posts.

Copilot · 2025-12-18T10:30:28Z

includes/wp-admin/class-admin.php

+		$count = \get_comments(
+			array(
+				'post_type' => $post_types,
+				'count'     => true,
+			)
+		);
+


The comment count query on line 577-582 is executed on every page load of the comments admin screen without caching. This could impact performance on sites with many comments. Consider caching the count using WordPress transients with a reasonable expiration time, and invalidating the cache when comments are added/modified on federated post types.

Suggested change

$count = \get_comments(

array(

'post_type' => $post_types,

'count' => true,

)

);

$transient_key = 'activitypub_federated_comment_count_' . \md5( \wp_json_encode( $post_types ) );

$count = \get_transient( $transient_key );

if ( false === $count ) {

$count = \get_comments(

array(

'post_type' => $post_types,

'count' => true,

)

);

// Cache the count for a short period to improve performance on large sites.

\set_transient( $transient_key, $count, \MINUTE_IN_SECONDS * 10 );

}

Copilot · 2025-12-18T10:30:29Z

includes/class-comment.php

+			// phpcs:ignore WordPress.Security.NonceVerification.Recommended
+			if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] && empty( $query->query_vars['count'] ) ) || self::hide_for() === $query->query_vars['post_type'] ) {
+				// Show only comments from hidden post types (Fediverse view).
+				$query->query_vars['post_type'] = self::hide_for();
+				$query->query_vars['status']    = 'all';
+			} else {
+				// Exclude comments from hidden post types.
+				$query->query_vars['post_type'] = array_diff( \get_post_types_by_support( 'comments' ), self::hide_for() );


The comparison self::hide_for() === $query->query_vars['post_type'] will always fail because hide_for() returns an array and $query->query_vars['post_type'] would be a string or array. This condition appears to be checking if the query is already filtered to hidden post types, but array comparison using === requires exact match of both values and order. Consider using a more robust check, such as comparing if the arrays contain the same values regardless of order, or if post_type is set and matches the hidden types.

Suggested change

// phpcs:ignore WordPress.Security.NonceVerification.Recommended

if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] && empty( $query->query_vars['count'] ) ) || self::hide_for() === $query->query_vars['post_type'] ) {

// Show only comments from hidden post types (Fediverse view).

$query->query_vars['post_type'] = self::hide_for();

$query->query_vars['status'] = 'all';

} else {

// Exclude comments from hidden post types.

$query->query_vars['post_type'] = array_diff( \get_post_types_by_support( 'comments' ), self::hide_for() );

$hidden_post_types = self::hide_for();

$post_type = isset( $query->query_vars['post_type'] ) ? $query->query_vars['post_type'] : null;

$is_hidden_post_type_query = false;

if ( is_string( $post_type ) ) {

$is_hidden_post_type_query = in_array( $post_type, $hidden_post_types, true );

} elseif ( is_array( $post_type ) ) {

// True if all requested post types are within the hidden set.

$is_hidden_post_type_query = empty( array_diff( $post_type, $hidden_post_types ) );

}

// phpcs:ignore WordPress.Security.NonceVerification.Recommended

if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] && empty( $query->query_vars['count'] ) ) || $is_hidden_post_type_query ) {

// Show only comments from hidden post types (Fediverse view).

$query->query_vars['post_type'] = $hidden_post_types;

$query->query_vars['status'] = 'all';

} else {

// Exclude comments from hidden post types.

$query->query_vars['post_type'] = array_diff( \get_post_types_by_support( 'comments' ), $hidden_post_types );

Copilot · 2025-12-18T10:30:29Z

includes/class-comment.php

-			if ( \get_option( 'activitypub_create_posts', false ) ) {
-				$query->query_vars['post_type'] = array_diff( \get_post_types_by_support( 'comments' ), array( Posts::POST_TYPE ) );
+			// phpcs:ignore WordPress.Security.NonceVerification.Recommended
+			if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] && empty( $query->query_vars['count'] ) ) || self::hide_for() === $query->query_vars['post_type'] ) {


The condition excludes count queries from the Fediverse view logic with empty( $query->query_vars['count'] ). However, the comment_views method on line 577-582 uses get_comments( array( 'post_type' => $post_types, 'count' => true ) ) to count federated comments. This count query will hit the else branch on line 712-714, which excludes hidden post types, resulting in a count of 0 for the Fediverse view badge. The count query should be allowed to use the hidden post types filter to get an accurate count.

Suggested change

if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] && empty( $query->query_vars['count'] ) ) || self::hide_for() === $query->query_vars['post_type'] ) {

if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] ) || self::hide_for() === $query->query_vars['post_type'] ) {

Copilot · 2025-12-18T10:30:29Z

includes/wp-admin/class-admin.php

+		}
+
+		// phpcs:ignore WordPress.Security.NonceVerification.Recommended
+		$is_fediverse_view = isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'];


Direct access to $_GET['comment_status'] without sanitization. While the phpcs:ignore comment acknowledges skipping nonce verification (which is acceptable for read-only filtering), the value should still be sanitized before use. Consider using sanitize_key() or validating against expected values to prevent potential injection issues.

Suggested change

$is_fediverse_view = isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'];

$comment_status = isset( $_GET['comment_status'] ) ? \sanitize_key( \wp_unslash( $_GET['comment_status'] ) ) : '';

$is_fediverse_view = ( 'federated' === $comment_status );

Copilot · 2025-12-18T10:30:29Z

includes/class-comment.php

-			if ( \get_option( 'activitypub_create_posts', false ) ) {
-				$query->query_vars['post_type'] = array_diff( \get_post_types_by_support( 'comments' ), array( Posts::POST_TYPE ) );
+			// phpcs:ignore WordPress.Security.NonceVerification.Recommended
+			if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] && empty( $query->query_vars['count'] ) ) || self::hide_for() === $query->query_vars['post_type'] ) {


Direct access to $_GET['comment_status'] without sanitization. While the phpcs:ignore comment acknowledges skipping nonce verification (which is acceptable for read-only filtering), the value should still be sanitized before use in the comparison. Consider using sanitize_key() or validating against expected values to prevent potential injection issues.

Suggested change

if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] && empty( $query->query_vars['count'] ) ) || self::hide_for() === $query->query_vars['post_type'] ) {

if ( ( isset( $_GET['comment_status'] ) && 'federated' === \sanitize_key( \wp_unslash( $_GET['comment_status'] ) ) && empty( $query->query_vars['count'] ) ) || self::hide_for() === $query->query_vars['post_type'] ) {

obenland · 2025-12-18T12:35:53Z

We're hiding these comments, why do we want to provide a way to surface them again?

pfefferle · 2025-12-18T12:44:56Z

Moderation!?

pfefferle · 2025-12-18T12:50:56Z

Transparency?

obenland · 2025-12-18T12:52:14Z

Hm, I've not fully thought this through, but my initial reaction is that we shouldn't hide them from the other views then, since this is the comment moderation page. Happy for us to add a separate view for it in that case though

pfefferle · 2025-12-18T13:02:31Z

I think it's fine to have them
separated, because it changes the current default behavior. But this might be a nice temp solution until we have a proper moderation possibility in the Reader.

Refactors the logic for handling admin comment queries by checking only for the presence of 'post_type' in query variables and setting the status to 'all', removing the previous conditional and redundant assignments.

pfefferle added 5 commits December 18, 2025 09:51

Add get_post_types_to_hide_comments_for method to Comment class.

0ccf3fe

This method returns post types whose comments should be hidden in the WordPress admin. Used for filtering comment queries and auto-approving comments on non-public post types like ap_post.

Add hide_for method to Comment class.

19f34f0

This method returns post types whose comments should be hidden in the WordPress admin comments list.

Add Fediverse view to admin comment screen

bd002e2

Introduces a 'Fediverse' filter in the admin comment views, allowing users to view comments from hidden post types such as 'ap_post'. Updates comment query logic to support this new view and display only relevant comments when selected.

Show comment count for Fediverse filter in admin

d73bb2c

Adds a comment count badge to the 'Fediverse' filter in the admin comments view and updates the query logic to better handle post type filtering for federated comments.

Fix post type check in admin comment query

bdbbc85

Replaces a generic post type check with a specific comparison to self::hide_for() in the admin comment query logic, ensuring only comments from the intended hidden post type are shown in the Fediverse view.

Copilot AI review requested due to automatic review settings December 18, 2025 10:22

pfefferle self-assigned this Dec 18, 2025

pfefferle requested a review from a team December 18, 2025 10:22

github-actions bot added [Feature] WP Admin [Tests] Includes Tests labels Dec 18, 2025

Copilot started reviewing on behalf of pfefferle December 18, 2025 10:22 View session

Copilot AI reviewed Dec 18, 2025

View reviewed changes

pfefferle added 2 commits December 18, 2025 14:14

Simplify admin comment query post type handling

9c0665c

Refactors the logic for handling admin comment queries by checking only for the presence of 'post_type' in query variables and setting the status to 'all', removing the previous conditional and redundant assignments.

Merge branch 'trunk' into add/fediverse-comments-filter

5d8f8a7

	Hide comments from specific post types in the WordPress admin comments list.
	Add Fediverse view to admin comments list to show comments from federated posts.

	if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] && empty( $query->query_vars['count'] ) ) \|\| self::hide_for() === $query->query_vars['post_type'] ) {
	if ( ( isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'] ) \|\| self::hide_for() === $query->query_vars['post_type'] ) {

	$is_fediverse_view = isset( $_GET['comment_status'] ) && 'federated' === $_GET['comment_status'];
	$comment_status = isset( $_GET['comment_status'] ) ? \sanitize_key( \wp_unslash( $_GET['comment_status'] ) ) : '';
	$is_fediverse_view = ( 'federated' === $comment_status );

Add Fediverse view to admin comments list #2663

Are you sure you want to change the base?

Add Fediverse view to admin comments list #2663

Uh oh!

Conversation

pfefferle commented Dec 18, 2025

Proposed changes:

Other information:

Testing instructions:

Changelog entry

Significance

Type

Message

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

obenland commented Dec 18, 2025

Uh oh!

pfefferle commented Dec 18, 2025

Uh oh!

pfefferle commented Dec 18, 2025

Uh oh!

obenland commented Dec 18, 2025

Uh oh!

pfefferle commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pfefferle commented Dec 18, 2025 •

edited

Loading