Skip to content

Conversation

@pfefferle
Copy link
Member

@pfefferle pfefferle commented Nov 18, 2025

The goal of this PR is to merge all necessary documentation so we can more effectively test the specific Claude skills introduced in #2454.

Added new documentation files for code linting, PHP class structure, and PHP coding standards. Updated development environment and pull request guides with detailed setup, workflow, and troubleshooting instructions. Introduced tests/README.md for testing reference. These changes improve onboarding, code quality, and contribution clarity for developers.

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Added new documentation files for code linting, PHP class structure, and PHP coding standards. Updated development environment and pull request guides with detailed setup, workflow, and troubleshooting instructions. Introduced tests/README.md for testing reference. These changes improve onboarding, code quality, and contribution clarity for developers.

Co-Authored-By: Konstantin Obenland <1398304+obenland@users.noreply.github.com>
@pfefferle pfefferle requested a review from obenland November 18, 2025 09:58
@pfefferle pfefferle self-assigned this Nov 18, 2025
Copilot AI review requested due to automatic review settings November 18, 2025 09:58
@pfefferle pfefferle added Docs Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. labels Nov 18, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive developer documentation to improve onboarding, code quality, and contribution clarity. The documentation covers development environment setup, testing patterns, pull request workflows, PHP coding standards, class structure organization, and code linting practices.

Key Changes

  • Added detailed testing reference guide with PHPUnit patterns, test organization, and debugging techniques
  • Expanded pull request guide with comprehensive checklists and workflows for the entire PR lifecycle
  • Created PHP coding standards reference covering WordPress standards, documentation, security, and performance
  • Added class structure guide documenting directory layout, namespace organization, and design patterns
  • Enhanced development environment guide with wp-env setup, Docker management, and troubleshooting
  • Added code linting reference covering PHP, JavaScript, and CSS standards with pre-commit automation

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/README.md New comprehensive testing reference with patterns, examples, and debugging guidance
docs/pull-request.md Significantly expanded from basic lifecycle to complete PR workflow with checklists and templates
docs/php-coding-standards.md New reference covering WordPress standards, naming conventions, security practices, and performance
docs/php-class-structure.md New guide documenting directory layout, class types, namespaces, and integration patterns
docs/development-environment.md Expanded from basic setup to comprehensive guide with wp-env config, Docker management, and troubleshooting
docs/code-linting.md New reference for linting tools, configuration, pre-commit hooks, and fixing common issues

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pfefferle and others added 3 commits November 18, 2025 11:22
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pfefferle and others added 3 commits November 18, 2025 15:18
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
pfefferle and others added 3 commits November 18, 2025 15:27
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
Co-authored-by: Konstantin Obenland <obenland@gmx.de>
Replace embedded PR template with a reference to the actual GitHub pull request template file at .github/PULL_REQUEST_TEMPLATE.md. This ensures consistency and avoids duplication.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pfefferle and others added 3 commits November 18, 2025 16:25
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pfefferle pfefferle merged commit 8bad57a into trunk Nov 18, 2025
5 checks passed
@pfefferle pfefferle deleted the update/consolidate-docs branch November 18, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants