[PLTFRM-1888] EnvVars Set/Delete: Add reload + message #2686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
rebeccahum
force-pushed
the
PLTFRM-1888
branch
from
5b4354f to
d102dfa
Compare
Contributor
Author
|
@yolih Can you check me on the wording here? TIA! |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds an optional manifest reload feature when setting or deleting environment variables, allowing changes to take effect immediately without requiring a new deployment. The feature includes user confirmation prompts and special messaging for Node.js applications about build-time versus runtime variable behavior.
- Adds
reloadManifestparameter to environment variable set and delete GraphQL mutations - Implements user confirmation prompt for reloading project configuration
- Shows Node.js-specific warning about build-time vs runtime environment variables
- Updates conditional messaging to only show deployment warning when reload is declined
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/envvar/api.ts | Adds typeId to app query to determine application type |
| src/lib/envvar/api-set.ts | Adds reloadManifest parameter to set environment variable mutation |
| src/lib/envvar/api-delete.ts | Adds reloadManifest parameter to delete environment variable mutation |
| src/bin/vip-config-envvar-set.js | Implements reload prompt, Node.js warning message, and conditional post-operation messaging |
| src/bin/vip-config-envvar-delete.js | Implements reload prompt, Node.js warning message, and conditional post-operation messaging |
| tests/bin/vip-config-envvar-set.js | Updates tests to cover reload confirmation flow and Node.js warning display |
| tests/bin/vip-config-envvar-delete.js | Updates tests to cover reload confirmation flow and Node.js warning display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sjinks
reviewed
Jan 7, 2026
sjinks
approved these changes
Jan 7, 2026
Co-Authored-By: Volodymyr Kolesnykov <volodymyr.kolesnykov@automattic.com>
rebeccahum
force-pushed
the
PLTFRM-1888
branch
from
ddc70e6 to
454a176
Compare
rebeccahum
force-pushed
the
PLTFRM-1888
branch
2 times, most recently
from
54c4222 to
65a8763
Compare
rebeccahum
force-pushed
the
PLTFRM-1888
branch
from
65a8763 to
a6dbc1e
Compare
rebeccahum
force-pushed
the
PLTFRM-1888
branch
from
a6dbc1e to
a8240b3
Compare
sjinks
approved these changes
Jan 7, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the environment variable API functions to support an optional manifest reload when adding or deleting environment variables.
On a WP app:
On a NodeJS app:
Changelog Description
Added
Pull request checklist
New release checklist