Skip to content

Conversation

@sjinks
Copy link
Member

@sjinks sjinks commented Dec 17, 2025

Description

This pull request updates the Docker Compose version check in the validateDockerInstalled function to be more inclusive of valid versions. Current version of docker-compose standalone binary is 5.x; our code checks for ^2.0.0 and, therefore, fails on 5.x.

Dependency validation update:

  • Relaxed the version constraint for Docker Compose in validateDockerInstalled to allow any version 2.0.0 or higher, instead of only versions matching the ^2.0.0 range. (src/lib/dev-environment/dev-environment-lando.ts)

Changelog Description

Fixed

  • Dev Environment: allow docker-compose newer than 2.x

Pull request checklist

New release checklist

Steps to Test

Install the docker-compose binary from https://github.com/docker/compose/releases and ensure that dev env works.

@github-actions
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a Docker Compose version validation issue that was preventing users from using docker-compose versions 3.x and higher (including the current 5.x). The validation was using ^2.0.0 which only allows 2.x versions, but the error message and intended behavior was to support any version 2.0.0 or higher.

  • Changed the semver range from ^2.0.0 (which matches >=2.0.0 <3.0.0) to >=2.0.0 (which matches 2.0.0 and all higher versions)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sjinks sjinks merged commit 539225c into trunk Dec 17, 2025
25 checks passed
@sjinks sjinks deleted the 218550-z branch December 17, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants