fix: remove console.log that breaks oneline printing in export-sql #2645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The console.log call for download URL was breaking the progress tracker's oneline printing format. Refactored to use a centralized formatting method that integrates properly with the progress tracker's stepSuccess output.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
rinatkhaziev
approved these changes
Nov 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the download URL was displayed using
console.log, which broke the progress tracker's oneline printing format when using the--skip-downloadoption.Changes
console.logcall that was interfering with the progress tracker's output formatgenerateDownloadURLOutputString()method to ensure consistent URL formattingprogressTracker.stepSuccess()Why
The
--skip-downloadoption (added in #2625) displayed the download URL usingconsole.log, which disrupted the progress tracker's oneline printing mechanism. This PR ensures the download URL is properly integrated with the progress tracker's output system.Changelog Description
Fixed
Changed
Pull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build./dist/bin/vip-cookies.js nom