Symfony autocomplete

[ecairol]

WIP

[ecairol]

@ahegyes how do you feel about this. When the user writes a command and hits TAB, besides displaying the available options and arguments, to also offer the user a full written example with placeholders?

--
At least on my Terminal the options are not selectable, and I think it could be useful to have a reference of the value types that can be used for each option, but I'm also having second thoughts about it.

[ahegyes]

how do you feel about this

I'm in favor of not doing that simply because I think it kinda clutters the terminal and I haven't seen it done anywhere else.

But I can see some value in it. However, is the example auto-generated or will that be another thing to remember to update if the options change? 🤔

[ecairol]

@ahegyes Yeah that's ok, it was an idea I had and wanted to hear opinions, but I wasn't 100% sold on it either. I haven't found a way to make it auto-generated so that's a con, it would need to be manually updated 👎

[ecairol]

@ahegyes some recent updates:

• I've implemented a Trait called Autocomplete, with a generic complete() function, and now all commands are using it. It works like a charm
• Removed the "example" part from the auto-complete
• Now the --help command skips the 1Password part and returns results much faster
• There was a conflict with Symphony autocomplete and the -c command, so I had to rename the --contractor option to -con

Would you mind testing when you have a chance?

[ecairol]

@fmfernandes since you're already familiar with this problem and its solution, would you mind taking a look at commit eae6cb4 and let me know if you see anything suspicious or have any suggestion or question?

[fmfernandes]

PR looks good. Left a couple comments regarding some return types I'd change to match the command's output.

[ecairol]

Thanks for those observations @fmfernandes, I've updated both cases here: c5978c9