Skip to content

Studio: Filter out deprecated warnings from fatal errors #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katinthehatsite merged 7 commits into from
Apr 9, 2026
Merged

Studio: Filter out deprecated warnings from fatal errors #3018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
70e586b
Filter out deprecated warnings from fatal errors
Apr 8, 2026
0e86caf
Merge branch 'trunk' of github.com:Automattic/studio into fix/pushing…
Apr 9, 2026
0e1e800
Ensure our error filtering approach is consistent with CLI
Apr 9, 2026
e9bd205
Apply changes to default exporter
Apr 9, 2026
016222f
Merge branch 'trunk' into fix/pushing-site-with-8.5
katinthehatsite Apr 9, 2026
81eccd1
Fix unit tests
Apr 9, 2026
9dec3c2
Merge branch 'fix/pushing-site-with-8.5' of github.com:Automattic/stu…
Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions apps/studio/src/lib/import-export/export/export-database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,13 @@ export async function exportDatabaseToFile(
// Execute the command to export directly to the temp file
// Use absolute path /wordpress/ because that's where site.path is mounted in the WASM filesystem
const vfsFilePath = `/wordpress/${ tempFileName }`;
const { stderr, exitCode } = await server.executeWpCliCommand(
const { exitCode } = await server.executeWpCliCommand(
`sqlite export ${ vfsFilePath } --require=/tmp/sqlite-command/command.php --enable-ast-driver`,
{
skipPluginsAndThemes: true,
}
);

if ( stderr ) {
throw new Error( `Database export failed: ${ stderr }` );
}

if ( exitCode ) {
throw new Error( 'Database export failed' );
}
Expand Down Expand Up @@ -58,9 +54,6 @@ export async function exportDatabaseToMultipleFiles(
skipPluginsAndThemes: true,
}
);
if ( tablesResult.stderr ) {
throw new Error( `Database export failed: ${ tablesResult.stderr }` );
}
if ( tablesResult.exitCode ) {
throw new Error( 'Database export failed' );
}
Expand Down Expand Up @@ -89,17 +82,13 @@ export async function exportDatabaseToMultipleFiles(
const vfsFilePath = `/wordpress/${ fileName }`;

// Execute the command to export directly to a temporary file in the project directory
const { stderr, exitCode } = await server.executeWpCliCommand(
const { exitCode } = await server.executeWpCliCommand(
`sqlite export ${ vfsFilePath } --tables=${ table } --require=/tmp/sqlite-command/command.php --enable-ast-driver`,
{
skipPluginsAndThemes: true,
}
);

if ( stderr ) {
throw new Error( `Database export failed: ${ stderr }` );
}

if ( exitCode ) {
throw new Error( 'Database export failed' );
}
Expand Down
10 changes: 4 additions & 6 deletions apps/studio/src/lib/import-export/export/exporters/default-exporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ export class DefaultExporter extends EventEmitter implements Exporter {
return [];
}

const { stderr, stdout } = await server.executeWpCliCommand(
const { exitCode, stdout } = await server.executeWpCliCommand(
'plugin list --status=active,inactive --fields=name,status,version --format=json',
{
skipPluginsAndThemes: true,
Expand All @@ -320,8 +320,7 @@ export class DefaultExporter extends EventEmitter implements Exporter {
try {
return parseJsonFromPhpOutput( stdout );
} catch ( error ) {
if ( stderr ) {
console.error( `Could not get information about plugins: ${ stderr }` );
if ( exitCode ) {
throw new Error(
'Could not get information about installed plugins to create meta.json file.'
);
Expand All @@ -340,7 +339,7 @@ export class DefaultExporter extends EventEmitter implements Exporter {
return [];
}

const { stderr, stdout } = await server.executeWpCliCommand(
const { exitCode, stdout } = await server.executeWpCliCommand(
'theme list --fields=name,status,version --format=json',
{
skipPluginsAndThemes: true,
Expand All @@ -352,8 +351,7 @@ export class DefaultExporter extends EventEmitter implements Exporter {
try {
return parseJsonFromPhpOutput( stdout );
} catch ( error ) {
if ( stderr ) {
console.error( `Could not get information about themes: ${ stderr }` );
if ( exitCode ) {
throw new Error(
'Could not get information about installed themes to create meta.json file.'
);
Expand Down
2 changes: 1 addition & 1 deletion apps/studio/src/lib/import-export/tests/export/exporters/default-exporter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ platformTestSuite( 'DefaultExporter', ( { normalize } ) => {
return Promise.resolve( {
stdout: '<a><br/>some html</ap>',
stderr: 'Error',
exitCode: 0,
exitCode: 1,
} );
default:
return Promise.resolve( { stdout: '', stderr: '', exitCode: 0 } );
Expand Down
Loading