Skip to content

Conversation

@wojtekn
Copy link
Contributor

@wojtekn wojtekn commented Dec 22, 2025

Related issues

  • N/A

Proposed Changes

I propose removing electron-devtools-installer dependency which uses deprecated Electron APIs and implementing native extension loading using session.extensions.loadExtension(). It eliminates deprecation warnings for session.loadExtension and session.getAllExtensions.

Testing Instructions

Confirm:

  • Builds go through
  • React DevTools and Redux DevTools load successfully in development mode
  • There are no deprecation warnings for extension-related APIs

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@wojtekn wojtekn requested a review from a team December 22, 2025 18:56
@wojtekn wojtekn self-assigned this Dec 22, 2025
@github-actions
Copy link
Contributor

📊 Performance Test Results

Comparing 245bcb5 vs trunk

site-editor

Metric trunk 245bcb5 Diff Change
load 10238.00 ms 9872.00 ms -366.00 ms 🟢 -3.6%

site-startup

Metric trunk 245bcb5 Diff Change
siteCreation 14259.00 ms 16492.00 ms +2233.00 ms 🔴 15.7%
siteStartup 5986.00 ms 5959.00 ms -27.00 ms 🟢 -0.5%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Copy link
Contributor

@katinthehatsite katinthehatsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, I did not see any regressions 👍

Image Image

@wojtekn wojtekn merged commit 4e7c8c3 into trunk Dec 23, 2025
10 checks passed
@wojtekn wojtekn deleted the update/electron-devtools-loader branch December 23, 2025 10:13
@mikaoelitiana
Copy link

Hello,

I have just cloned the repo and started a fresh dev instance of studio but it seems the dev extensions are not installed automatically anymore. I have the following error :

Failed to load REACT_DEVELOPER_TOOLS extension: Error: ENOENT: no such file or directory, access '/Users/mikaoelitiana/Library/Application Support/Studio/extensions/fmkadmapgofadopljbjfkapdkoienihi'
    at async Module.access (node:internal/fs/promises:608:10)
    at async loadDevToolsExtensions (/Users/mikaoelitiana/Developer/studio/dist/main/index.js:7577:7)
    at async EventEmitter.<anonymous> (/Users/mikaoelitiana/Developer/studio/dist/main/index.js:7688:7) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'access',
  path: '/Users/mikaoelitiana/Library/Application Support/Studio/extensions/fmkadmapgofadopljbjfkapdkoienihi'
}
Failed to load REDUX_DEVTOOLS extension: Error: ENOENT: no such file or directory, access '/Users/mikaoelitiana/Library/Application Support/Studio/extensions/lmhkpmbekcpmknklioeibfkpmmfibljd'
    at async Module.access (node:internal/fs/promises:608:10)
    at async loadDevToolsExtensions (/Users/mikaoelitiana/Developer/studio/dist/main/index.js:7577:7)
    at async EventEmitter.<anonymous> (/Users/mikaoelitiana/Developer/studio/dist/main/index.js:7688:7) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'access',
  path: '/Users/mikaoelitiana/Library/Application Support/Studio/extensions/lmhkpmbekcpmknklioeibfkpmmfibljd'
}

What is the recommended way to install the extensions so they can be loaded here?

@wojtekn
Copy link
Contributor Author

wojtekn commented Jan 20, 2026

@mikaoelitiana, thanks for reporting the issue.

I opened a PR that suppose to add installation back: #2431

@mikaoelitiana
Copy link

@mikaoelitiana, thanks for reporting the issue.

I opened a PR that suppose to add installation back: #2431

Thanks for the quick solution 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants