[Diagnostic] Disable GMS Wearable integration to isolate Play Protect crash#1815
Draft
mzorz wants to merge 1 commit into
Draft
[Diagnostic] Disable GMS Wearable integration to isolate Play Protect crash#1815mzorz wants to merge 1 commit into
mzorz wants to merge 1 commit into
Conversation
Strip every phone-app touchpoint with Google Play Services Wearable to isolate whether the recurring 'Google Play Protect Service keeps stopping' dialog reported by users is triggered by our binding to GMS Wearable. - Drop play-services-wearable dependency - Drop wearApp bundling of the :Wear module - Remove SimplenoteWearListenerService and its MESSAGE_RECEIVED filter - Remove the now-orphan com.google.android.gms.version meta-data (Wearable was the only GMS client lib in use) Diagnostic build only -- not intended to merge. See DODROID-884.
Collaborator
Generated by 🚫 Danger |
Collaborator
|
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Diagnostic-only branch. Do not merge.
Several users report that the Android system dialog "Google Play Protect Service keeps stopping" appears every few minutes (and sometimes immediately) while editing notes in Simplenote. See DODROID-884 and the forum thread. One user is on a Pixel 6 Pro (likely Android 16 stable) where the dialog appears immediately on app launch.
The dialog is a Google Play Services process crash, not a Simplenote crash. The leading hypothesis is that our
WearableListenerServicecausing GMS to bind to our app for Wearable transport / node discovery is what tickles the GMS Chimera crash on these Android builds. Simplenote is unusual in hosting that service alongside a continuous Simperium WebSocket session, which lines up with the user observation that "no other apps do this."This branch strips every phone-app touchpoint with GMS Wearable:
com.google.android.gms:play-services-wearable:19.0.0wearApp project(':Wear')bundlingSimplenoteWearListenerServiceand itsMESSAGE_RECEIVEDintent filtercom.google.android.gms.versionmeta-data (Wearable was the only GMS client lib)The
:Wearmodule source is untouched.Test
./gradlew :Simplenote:assembleDebugSimplenote/build/outputs/apk/debug/Simplenote-debug.apk(applicationIdcom.automattic.simplenote.debug, installs side-by-side with production).WearableListenerServiceis still on the device and Play Protect could still trigger from it.org.apache.http.legacyuses-library, GMS Play Protect on those Android builds).Review
com.google.android.gms.wearable.*.grepwas clean at branch time.note_addedstring (used only by the deleted service) is intentionally left invalues*/strings.xmlto keep this branch a one-variable experiment. If we ever promote any of this to a permanent change those strings should go.:Wear) source is unchanged; only the bundling is removed.Release
No release notes needed. This branch is diagnostic and not intended to ship.