fix(web-preview): right-align toolbar close button#4740
Open
adekbadek wants to merge 1 commit into
Open
Conversation
Use flex with flex-end so the device size and close buttons cluster at the right edge instead of stretching across the toolbar when no title is set (e.g. the campaigns prompt preview).
|
🎉 This PR is included in version 6.39.5-hotfix-web-preview-toolbar-right-alignment.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Hotfix targeting
release..newspack-web-preview__toolbar-rightusesdisplay: grid; grid-template-columns: repeat(2, 1fr). When notitleprop is passed to<WebPreview>(e.g. the Newspack Campaigns prompt preview), the toolbar has only one flex child and the two 1fr columns end up spreading the device-size dropdown and the close button across the full width of the toolbar – the close button is no longer right-aligned next to the device dropdown.Switch the layout to
display: flex; justify-content: flex-endso the two buttons always cluster together on the right edge, regardless of whether a title is rendered.How to test the changes in this Pull Request:
Tested locally on the components demo page (
/wp-admin/admin.php?page=newspack-components-demo, the "Web Previews" section, which has one<WebPreview>withtitleand one without):Steps:
n build newspack-plugin/wp-admin/admin.php?page=newspack-components-demoOther information:
packages/components/src/web-preview/style.scss(1 file, +2 / -3).WebPreviewfromnewspack-components(newspack-popups, newspack-newsletters, newspack-ads, newspack-multibranded-site, newspack-block-theme, newspack-manager, newspack-listings). Layout is backwards compatible.