-
Notifications
You must be signed in to change notification settings - Fork 850
Forms: help assistive technology users notice submission confirmation #46705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances accessibility for the Jetpack Forms feature by adding the aria-live="polite" attribute to the form submission confirmation message container, enabling assistive technology users (such as screen readers) to be automatically notified when a form is successfully submitted.
Changes:
- Added
aria-live="polite"attribute to the noscript submission confirmation container - Updated changelog entries in both the Jetpack plugin and Forms package
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/packages/forms/src/contact-form/class-contact-form.php | Added aria-live attribute to submission confirmation div for accessibility |
| projects/plugins/jetpack/changelog/update-forms-submit-aria-live | Added changelog entry for the Jetpack plugin |
| projects/packages/forms/changelog/update-forms-submit-aria-live | Added changelog entry for the Forms package |
| Significance: minor | ||
| Type: added | ||
|
|
||
| Help assistive technology users notice submission confirmation." |
Copilot
AI
Jan 21, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry has an extra quotation mark at the end. It should end with a period only, not a period followed by a quotation mark.
| Help assistive technology users notice submission confirmation." | |
| Help assistive technology users notice submission confirmation. |
| @@ -0,0 +1,4 @@ | |||
| Significance: minor | |||
| Type: added | |||
Copilot
AI
Jan 21, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog type should be consistent across both changelog entries. The plugin changelog uses "enhancement" while the package changelog uses "added". Since this is an improvement to existing functionality rather than entirely new functionality, "enhancement" is more appropriate and consistent.
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
|
Closing in favor of #46707 |
Fixes FORMS-550
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: