Skip to content

Conversation

@simison
Copy link
Member

@simison simison commented Jan 21, 2026

Fixes FORMS-550

Proposed changes:

  • Help assistive technology users notice submission confirmation by adding aria-live attribute to submission confirmation container.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Submit form using voice; you should hear submission confirmation.

@simison simison requested a review from enejb January 21, 2026 14:25
@simison simison added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jan 21, 2026
Copilot AI review requested due to automatic review settings January 21, 2026 14:25
@simison simison added [Focus] Accessibility Improving usability for all users (a11y) [Status] Needs Review This PR is ready for review. [Package] Forms [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. Enhancement labels Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-submit-aria-live branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-submit-aria-live

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: February 3, 2026
    • Code freeze: February 3, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances accessibility for the Jetpack Forms feature by adding the aria-live="polite" attribute to the form submission confirmation message container, enabling assistive technology users (such as screen readers) to be automatically notified when a form is successfully submitted.

Changes:

  • Added aria-live="polite" attribute to the noscript submission confirmation container
  • Updated changelog entries in both the Jetpack plugin and Forms package

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
projects/packages/forms/src/contact-form/class-contact-form.php Added aria-live attribute to submission confirmation div for accessibility
projects/plugins/jetpack/changelog/update-forms-submit-aria-live Added changelog entry for the Jetpack plugin
projects/packages/forms/changelog/update-forms-submit-aria-live Added changelog entry for the Forms package

Significance: minor
Type: added

Help assistive technology users notice submission confirmation."
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry has an extra quotation mark at the end. It should end with a period only, not a period followed by a quotation mark.

Suggested change
Help assistive technology users notice submission confirmation."
Help assistive technology users notice submission confirmation.

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,4 @@
Significance: minor
Type: added
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog type should be consistent across both changelog entries. The plugin changelog uses "enhancement" while the package changelog uses "added". Since this is an improvement to existing functionality rather than entirely new functionality, "enhancement" is more appropriate and consistent.

Copilot generated this review using guidance from repository custom instructions.
@jp-launch-control
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison
Copy link
Member Author

simison commented Jan 26, 2026

Closing in favor of #46707

@simison simison closed this Jan 26, 2026
@simison simison deleted the update/forms-submit-aria-live branch January 26, 2026 11:02
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement [Feature] Contact Form [Feature] Forms Blocks Blocks designed to streamline user input and engagement, such as contact, newsletter sign-ups, etc. [Focus] Accessibility Improving usability for all users (a11y) [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants