CRM: CSV import path separator by haqadn · Pull Request #46684 · Automattic/jetpack

haqadn · 2026-01-20T16:50:42Z

CSV Importer: Fix path separator issue causing import failures on Windows servers

Fixes JETCRM-64

Proposed changes:

Replaced a hardcoded forward slash (/) with DIRECTORY_SEPARATOR when constructing the temporary directory path in ZeroBSCRM.CSVImporter.php. This resolves an issue where realpath() on Windows returns backslashes, causing a path mismatch and failure in a security check (str_starts_with()).

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Set up a WordPress environment on a Windows server.
Install and activate Jetpack CRM.
Go to Jetpack CRM → Contacts -> Import.
Upload a valid CSV file.
Attempt to import the CSV using either Importer Pro or the core importer.
Expected Result: The import process should start, and the dashboard should load the import progress.
Actual Result (before fix): The import fails immediately with the message: “There was an error processing your CSV file. Please try again.”

Replace hardcoded forward slash '/' with DIRECTORY_SEPARATOR constant on line 155. On Windows, realpath() returns paths with backslashes (e.g., C:\Windows\Temp), but the hardcoded '/' created a mixed path (C:\Windows\Temp/). This caused str_starts_with() check on line 247 to fail, preventing CSV imports. Co-authored-by: adnan007.id <adnan007.id@gmail.com>

cursor · 2026-01-20T16:50:44Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

github-actions · 2026-01-20T16:51:47Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copilot

Pull request overview

This PR fixes a critical bug in the CSV importer that prevented imports from working on Windows servers. The issue occurred because a hardcoded forward slash (/) was used in path construction, while Windows realpath() returns backslashes, causing a security check to fail.

Changes:

Updated path separator in CSV importer to use DIRECTORY_SEPARATOR instead of hardcoded / for cross-platform compatibility
Added changelog entry documenting the fix

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
projects/plugins/crm/includes/ZeroBSCRM.CSVImporter.php	Replaced hardcoded forward slash with `DIRECTORY_SEPARATOR` when constructing temp directory path to fix Windows compatibility
projects/plugins/crm/changelog/fix-csv-import-path-separator-windows	Added changelog entry for the path separator fix

Copilot · 2026-01-20T16:55:08Z

+Significance: patch
+Type: fixed
+
+CSV Importer: fix path separator issue causing import failures on Windows servers.


The changelog entry should start with a capital letter. Change "fix" to "Fix" to follow the project's changelog guidelines.

Copilot · 2026-01-20T16:55:46Z

@haqadn I've opened a new pull request, #46685, to work on those changes. Once the pull request is ready, I'll request review from you.

jp-launch-control · 2026-01-20T16:55:58Z

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

grzegorz-cp

Good replacement.

grzegorz-cp · 2026-01-23T03:54:00Z

I'm not sure how to test this on a Windows server but the code makes sense and it's a small change so I approved it.

github-actions Bot added [Plugin] CRM Issues about the Jetpack CRM plugin [Status] In Progress labels Jan 20, 2026

github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jan 20, 2026

haqadn added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jan 20, 2026

haqadn requested review from a team and mikestottuk January 20, 2026 16:52

haqadn marked this pull request as ready for review January 20, 2026 16:53

Copilot AI review requested due to automatic review settings January 20, 2026 16:53

haqadn self-assigned this Jan 20, 2026

Copilot started reviewing on behalf of haqadn January 20, 2026 16:53 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 20, 2026

Capitalize changelog entry per style guidelines #46685

Closed

Fix capitalization

c2aa97e

Copilot AI review requested due to automatic review settings January 20, 2026 16:57

Copilot started reviewing on behalf of haqadn January 20, 2026 16:58 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

haqadn changed the title ~~CSV import path separator~~ CRM: CSV import path separator Jan 20, 2026

grzegorz-cp approved these changes Jan 23, 2026

View reviewed changes

haqadn merged commit 332d546 into trunk Jan 26, 2026
74 checks passed

haqadn deleted the cursor/JETCRM-64-csv-import-path-separator-c311 branch January 26, 2026 12:35

github-actions Bot removed [Status] In Progress [Status] Needs Review This PR is ready for review. labels Jan 26, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CRM: CSV import path separator#46684

CRM: CSV import path separator#46684
haqadn merged 2 commits intotrunkfrom
cursor/JETCRM-64-csv-import-path-separator-c311

haqadn commented Jan 20, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Jan 20, 2026

Uh oh!

github-actions Bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 20, 2026

Uh oh!

Copilot AI commented Jan 20, 2026

Uh oh!

jp-launch-control Bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

grzegorz-cp left a comment

Uh oh!

grzegorz-cp commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

haqadn commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

cursor Bot commented Jan 20, 2026

Uh oh!

github-actions Bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jan 20, 2026

Uh oh!

jp-launch-control Bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

grzegorz-cp left a comment

Choose a reason for hiding this comment

Uh oh!

grzegorz-cp commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

haqadn commented Jan 20, 2026 •

edited

Loading

github-actions Bot commented Jan 20, 2026 •

edited

Loading

jp-launch-control Bot commented Jan 20, 2026 •

edited

Loading