Skip to content

Composer: raise the minimum supported versions of all CS dependencies #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GaryJones merged 2 commits into from
Jul 25, 2025
Merged

Composer: raise the minimum supported versions of all CS dependencies #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b3078
Composer: raise the minimum supported versions of all CS dependencies
jrfnl Jul 14, 2025
af4f80d
Performance/FetchingRemoteData: remove redundant method
jrfnl Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ The rulesets use rules from the [WordPress Coding Standards](https://github.com/
## Minimal requirements

* PHP 5.4+
* [PHPCS 3.8.0+](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
* [PHPCSUtils 1.0.9+](https://github.com/PHPCSStandards/PHPCSUtils)
* [PHPCSExtra 1.2.1+](https://github.com/PHPCSStandards/PHPCSExtra)
* [WPCS 3.0.0+](https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/releases)
* [VariableAnalysis 2.11.17+](https://github.com/sirbrillig/phpcs-variable-analysis/releases)
* [PHPCS 3.13.2+](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
* [PHPCSUtils 1.1.0+](https://github.com/PHPCSStandards/PHPCSUtils)
* [PHPCSExtra 1.4.0+](https://github.com/PHPCSStandards/PHPCSExtra)
* [WPCS 3.1.0+](https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/releases)
* [VariableAnalysis 2.12.0+](https://github.com/sirbrillig/phpcs-variable-analysis/releases)

## Installation

Expand Down
34 changes: 0 additions & 34 deletions WordPressVIPMinimum/Sniffs/Performance/FetchingRemoteDataSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,40 +94,6 @@ public function process_parameters( $stackPtr, $group_name, $matched_content, $p
}
}

/**
* Process the function if no parameters were found.
*
* {@internal This method is only needed for handling PHP 8.1+ first class callables on WPCS < 3.2.0.
* Once the minimum supported WPCS is 3.2.0 or higher, this method should be removed.}
*
* @param int $stackPtr The position of the current token in the stack.
* @param string $group_name The name of the group which was matched.
* @param string $matched_content The token content (function name) which was matched
* in lowercase.
*
* @return void
*/
public function process_no_parameters( $stackPtr, $group_name, $matched_content ) {
// Check if this is a first class callable.
$next = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $stackPtr + 1 ), null, true );
if ( $next === false
|| $this->tokens[ $next ]['code'] !== T_OPEN_PARENTHESIS
|| isset( $this->tokens[ $next ]['parenthesis_closer'] ) === false
) {
// Live coding/parse error. Ignore.
return;
}

// First class callable.
$firstNonEmpty = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $next + 1 ), null, true );
if ( $this->tokens[ $firstNonEmpty ]['code'] === T_ELLIPSIS ) {
$secondNonEmpty = $this->phpcsFile->findNext( Tokens::$emptyTokens, ( $firstNonEmpty + 1 ), null, true );
if ( $this->tokens[ $secondNonEmpty ]['code'] === T_CLOSE_PARENTHESIS ) {
$this->add_contents_unknown_warning( $stackPtr, [ $matched_content ] );
}
}
}

/**
* Process the function if it is used as a first class callable.
*
Expand Down
12 changes: 6 additions & 6 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@
],
"require": {
"php": ">=5.4",
"phpcsstandards/phpcsextra": "^1.2.1",
"phpcsstandards/phpcsutils": "^1.0.11",
"sirbrillig/phpcs-variable-analysis": "^2.11.18",
"squizlabs/php_codesniffer": "^3.9.2",
"wp-coding-standards/wpcs": "^3.1.0"
"phpcsstandards/phpcsextra": "^1.4.0",
"phpcsstandards/phpcsutils": "^1.1.0",
"sirbrillig/phpcs-variable-analysis": "^2.12.0",
"squizlabs/php_codesniffer": "^3.13.2",
"wp-coding-standards/wpcs": "^3.2.0"
},
"require-dev": {
"php-parallel-lint/php-parallel-lint": "^1.4.0",
"php-parallel-lint/php-console-highlighter": "^1.0.0",
"phpcompatibility/php-compatibility": "^9",
"phpcsstandards/phpcsdevtools": "^1.0",
"phpcsstandards/phpcsdevtools": "^1.2.3",
"phpunit/phpunit": "^4 || ^5 || ^6 || ^7 || ^8 || ^9"
},
"config": {
Expand Down