Skip to content

Conversation

@sankalps0549
Copy link
Collaborator

Description

This PR aims to bring the integration tests that have been developed so far on the feature branch to the main branch

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Checklist

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly
  • I have added a note to CHANGELOG.md describing my changes
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Testing

The tests can be run using the command

python run.py test --integration

Additional Notes

The early merge of the feature branch was prompted because we want the developed integration tests as part of our development process.

sankalps0549 and others added 27 commits September 15, 2025 21:39
* Vector Class Integration Tests

* Review Fixes

* Fixes

* Brackets fix

* Adding SPDX header

* Type order fix
* StringArray Class Tests

* to_list function fix

* add spdx headers
* IntegerArray Class Integration Tests

* Docstring fixes

* Review comments fixes

* Add SPDX Header
* DoubleArray Class Integration Tests

* Updating unit test

* Add SPDX Header
* ImportOptions class integration tests

* Marker additions

* Code review fixes
* Adding models and model fixtures

* MeshSummary Integration Tests

* Test Data Generation and Test fixes

* README update

* README update

* Comment fix
* Adding models and model fixtures

* MeshSummary Integration Tests

* Test Data Generation and Test fixes

* README update

* README update

* Comment fix

* Add non-model based data generation

* Synergy Integration Tests

* Adding pygetwindow to requirements

* Windows size updates and Fixture updates

* Copilot review fixes

* Zipping study_files

* Zip File name changes

* Metadata for Test data

* Unzip files in test data generation

* README updates

* Review fixes

* Removed ModelType enum

* Review fixes

* Lint fixes

* Project clean up

* Revert "Project clean up"

This reverts commit 1f16653.

* Remove edition assert
* CADManager Integration Tests

* CADManager none tests

* Review comment fix
… Field to Test Data Generation (#32)

* Child Markers, Json File Name marker, Synergy in data generation

* Review fixes

* Review fixes
* Property Integration Tests and Child Markers introduction
* New Infra

* Updating readme, removing childmarkers

* Review fix

* Timezone added to metadata, docopt command clarification
* EntList Integration Tests

* Update tests/api/integration_tests/test_integration_ent_list.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* SelectFromSavedList function test

* Refactoring for new infra

* SavedList tests

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* PredicateManager Integration Tests

* Add marker to unit test
* Remove metadata from integration tests

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* PropertyEditor Integration Tests

* Review fixes
@sankalps0549 sankalps0549 requested a review from Copilot January 22, 2026 09:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces integration tests for the moldflow-api module, bringing test infrastructure and test suites from a feature branch to the main branch. The changes include a comprehensive testing framework with fixtures, data generation utilities, and multiple test suites for various API components.

Changes:

  • Added integration test framework with pytest fixtures, file set management, and baseline data handling
  • Implemented test suites for VectorArray, Vector, Synergy, StringArray, PropertyEditor, PredicateManager, MeshSummary, MaterialProperty, IntegerArray, ImportOptions, EntList, DoubleArray, CustomProperty, and CADManager
  • Added data generation utilities and helper functions for creating test baselines

Reviewed changes

Copilot reviewed 79 out of 92 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/core/test_helper.py Removed unused test cases and import for _mf_array_to_list
tests/api/unit_tests/*.py Added pytest markers for better test organization
tests/api/integration_tests/test_suite_/test_integration_.py New integration test files for various API components
tests/api/integration_tests/test_suite_/generate_expected_data_.py Data generation scripts for test baselines
tests/api/integration_tests/test_suite_*/data.json Baseline test data files
tests/api/integration_tests/conftest.py Shared fixtures for integration tests
tests/api/integration_tests/constants.py Constants and enums for test configuration
tests/api/integration_tests/data_generation/*.py Data generation utilities and helpers
tests/api/integration_tests/study_files/* Study files and project data for testing
tests/api/integration_tests/README.md Documentation for integration testing framework
src/moldflow/vector_array.py Updated docstrings and type hints
src/moldflow/vector.py Updated docstrings and type hints
src/moldflow/string_array.py Updated implementation and type hints
src/moldflow/integer_array.py Updated implementation and type hints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

@sankalps0549 sankalps0549 requested a review from Copilot January 22, 2026 09:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 79 out of 92 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sankalps0549
Copy link
Collaborator Author

Hi @osinjoku
Can you please check the security issues. I think we can clear them, just want your confirmation.

@sankalps0549 sankalps0549 merged commit a02362f into main Jan 22, 2026
21 checks passed
@sankalps0549 sankalps0549 deleted the feature/integration-tests branch January 22, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants