Fixed Smagorinsky implementation and added JAX backend version #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing Guidelines
Fixes #149
Fixed Warp implementation: the kernel called self._warp_u_vec(), but that method doesn’t exist anywhere in the codebase.
It was also hard-coded to 3D. the strain logic accessed _c[2, l] and assumed d == 3, so it can’t work for 2D lattices.
The strain classification was also incorrect. It used (c_x + c_y + c_z) to decide “diagonal vs off-diagonal”. With signed lattice velocities (−1/0/1), that condition does not reliably represent |c| so the test was not passing. The method wrote _fout[l] directly to fout instead of casting to self.store_dtype, unlike BGK/KBC Warp kernels.
Added JAX implementation for Smagorinsky
Added tests for both implementations
examples run with both backends with no issues (e.g. run lid driven cavity).
Description
Type of change
How Has This Been Tested?
Linting and Code Formatting
Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.
To run Ruff, execute the following command from the root of the repository:
ruff check .