-
Notifications
You must be signed in to change notification settings - Fork 495
fix: docker, broken npm build script and missing dependency #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ruant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical issues related to the project's build system and dependency management. It ensures that the Docker environment correctly incorporates all required package configurations, integrates a previously missing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdds a Dockerfile COPY for libs/spec-parser package metadata, introduces Changes
Sequence Diagram(s)(omitted — changes do not introduce a multi-component sequential workflow that meets diagram criteria) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses several build-related issues by fixing the npm build script, adding a missing dependency, and updating the Dockerfile to include the new spec-parser library. My review identified a critical typo in the Dockerfile that needs to be corrected for the Docker build to succeed. I've also provided a suggestion to improve the consistency and maintainability of the npm build script in package.json. The other changes appear to be correct.
Dockerfile
Outdated
| COPY libs/utils/package*.json ./libs/utils/ | ||
| COPY libs/prompts/package*.json ./libs/prompts/ | ||
| COPY libs/platform/package*.json ./libs/platform/ | ||
| COPY libs/spep-parser/package*.json ./libs/spec-parser/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json
Outdated
| "dev:full": "npm run build:packages && concurrently \"npm run _dev:server\" \"npm run _dev:web\"", | ||
| "build": "npm run build:packages && npm run build --workspace=apps/ui", | ||
| "build:packages": "npm run build -w @automaker/types && npm run build -w @automaker/platform && npm run build -w @automaker/utils -w @automaker/spec-parser && npm run build -w @automaker/prompts -w @automaker/model-resolver -w @automaker/dependency-resolver && npm run build -w @automaker/git-utils", | ||
| "build:packages": "npm run build -w @automaker/types && npm run build -w @automaker/platform && npm run build -w @automaker/utils && npm run build -w @automaker/spec-parser && npm run build -w @automaker/prompts -w @automaker/model-resolver -w @automaker/dependency-resolver && npm run build -w @automaker/git-utils", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change serializes the build for @automaker/utils and @automaker/spec-parser, which likely fixes a build issue. However, the script remains inconsistent as other packages are still built in parallel using multiple -w flags in a single command (e.g., @automaker/prompts and @automaker/model-resolver).
For improved consistency and to prevent similar issues in the future, I suggest serializing all the package builds. This makes the build order explicit and easier to debug.
| "build:packages": "npm run build -w @automaker/types && npm run build -w @automaker/platform && npm run build -w @automaker/utils && npm run build -w @automaker/spec-parser && npm run build -w @automaker/prompts -w @automaker/model-resolver -w @automaker/dependency-resolver && npm run build -w @automaker/git-utils", | |
| "build:packages": "npm run build -w @automaker/types && npm run build -w @automaker/platform && npm run build -w @automaker/utils && npm run build -w @automaker/spec-parser && npm run build -w @automaker/prompts && npm run build -w @automaker/model-resolver && npm run build -w @automaker/dependency-resolver && npm run build -w @automaker/git-utils", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@Dockerfile`:
- Line 28: The Dockerfile has a typo in the COPY instruction: the source path
string "libs/spep-parser/package*.json" is incorrect and should be
"libs/spec-parser/package*.json"; update the COPY line that reads COPY
libs/spep-parser/package*.json ./libs/spec-parser/ to use the correct source
path so the build can find the package.json files.
🧹 Nitpick comments (1)
apps/ui/package.json (1)
108-108: Clarify the rationale for supporting both Zod v3 and v4.The version constraint
^3.24.1 || ^4.0.0spans two major versions. Since zod is used directly only inapps/ui/src/routes/terminal.tsx, confirm whether both versions are actually needed or if the range can be narrowed to a single major version to avoid potential inconsistencies.
zoddependency