Skip to content

feat: allow editing HOTP counter in entry edit UI (#1517) #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddjain wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: allow editing HOTP counter in entry edit UI (#1517) #1519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions _locales/en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,10 @@
"message": "Counter Based",
"description": "Counter Based"
},
"counter": {
"message": "Counter",
"description": "HOTP counter value"
},
"resize_popup_page": {
"message": "Preferences",
"description": "Popup Page Settings"
Expand Down
16 changes: 16 additions & 0 deletions src/components/Popup/EntryComponent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,18 @@
v-on:change="entry.update(encryption)"
/>
</div>
<div
class="issuerEdit"
v-if="entry.type === OTPType.hotp || entry.type === OTPType.hhex"
>
<input
type="number"
min="0"
v-model.number="entry.counter"
v-bind:placeholder="i18n.counter"
v-on:change="onCounterChange(entry)"
/>
</div>
<div
class="showqr"
v-if="shouldShowQrIcon(entry)"
Expand Down Expand Up @@ -194,6 +206,10 @@ export default Vue.extend({
}, 3000);
return;
},
onCounterChange(entry: OTPEntry) {
entry.generate();
entry.update();
},
async copyCode(entry: OTPEntry) {
if (
this.$store.state.style.style.isEditing ||
Expand Down