-
Notifications
You must be signed in to change notification settings - Fork 69
Cruz Mendez #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CruzMendez
wants to merge
2
commits into
AustinCodingAcademy:master
Choose a base branch
from
CruzMendez:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cruz Mendez #33
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,18 @@ | ||
|
|
||
| //in the function map, create a new array and store in a variable | ||
| //loop theArray and call the fnc for each thing in the array, | ||
| //loop theArray and call the fnc ( fnc() )for each thing in the array, | ||
| // passing in the item from the current loop into the call to fnc | ||
| //add the returned value from fnc to the new array | ||
| //return the new array | ||
| //return the new array (1.square brackets, 2.for loop, add item=push in js syntax, all these functions use 'loop') | ||
| export function map(theArray, fnc){ | ||
|
|
||
| var newArray = []; | ||
| for(var i = 0; i < theArray.length; i ++){ | ||
| var currentItem = theArray[i]; | ||
| fnc(currentItem); //pass in the 'thing' | ||
| var returnedItem = fnc(currentItem); | ||
| newArray.push(returnedItem); //newArray[i] = (returnedItem) | ||
| } | ||
| return newArray; //outside of the loop so that it only happens once. | ||
| } | ||
|
|
||
| //create a new array | ||
|
|
@@ -14,7 +21,17 @@ export function map(theArray, fnc){ | |
| //fnc will return true or false, if true add the item to the new array else do not | ||
| //return the new array | ||
| export function filter(theArray, fnc){ | ||
|
|
||
| var shortNamesArray = []; | ||
| for(var i = 0; i < theArray.length; i ++){ | ||
| var currentItem = theArray[i]; | ||
| fnc(currentItem); | ||
| var returnedItem = fnc(currentItem); | ||
| if (returnedItem = true) { | ||
| shortNamesArray.push(returnedItem); | ||
| } | ||
| } | ||
| // console.log(shortNameArray); | ||
| return shortNameArray; | ||
| } | ||
|
|
||
|
|
||
|
|
@@ -23,7 +40,17 @@ export function filter(theArray, fnc){ | |
| //fnc will return true or false, if true return the item | ||
| //return null | ||
| export function find(theArray, fnc){ | ||
|
|
||
| for(var i = 0; i < theArray.length; i ++){ | ||
| var currentItem = theArray[i]; | ||
| fnc(currentItem); | ||
| var returnedItem = fnc(currentItem); | ||
| if (returnedItem) { | ||
| return returnedItem; | ||
| } else { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in general, you don't ever want to have a else statement return in a loop |
||
| return null; | ||
| } | ||
| } | ||
| // console.log(returnedItem); | ||
| } | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double check you code here.
how do you compare things to true or false in an if statement