-
Notifications
You must be signed in to change notification settings - Fork 50
Clayton.Berger.ATX.Advanced1.First React App #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ivome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!!!
| @@ -0,0 +1,12 @@ | |||
| import React from "react"; | |||
| function Component7() { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to use consistent line spacing between import statements and code (1 empty line)
src/components/Header.js
Outdated
| ); | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary whitespace...
src/components/Main.js
Outdated
| Day 5 - Learning Teams submit project proposals<br /> | ||
| Day 9 - Learning Team Check-ins<br /> | ||
| Day 15 - Learning Team Check-ins<br /> | ||
| Day 20 - Learning Team Project Presentations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent content of elements by 2 spaces
| function Smiley() { | ||
| return ( | ||
| <div className="Smiley"> | ||
| <img src={face} className="App-logo" alt="logo" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check eslint indentation errors here.
Not sure how to properly render() an " ' ". When I do the code gets highlighted but it still renders on the page.