nick.rodriguez.atx.advanced.1 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivome
reviewed
May 10, 2017
ivome
left a comment
ivome
left a comment
There was a problem hiding this comment.
Overall the functionality looks OK. You do have quite a few issues in your code that eslint should tell you about. Make sure you have the linter activated in your IDE and always fix all the errors right away. That prevents you from making lots of unnecessary mistakes...
| function Body() { | ||
| return ( | ||
|
|
||
| <h1> </h1> |
| } | ||
|
|
||
|
|
||
| export default Header; |
|
|
||
| handleUserClick(event) { | ||
| console.log("Handle click", event); | ||
| console.log("the id is: ",event.id) |
| <p key={userNames.id} onClick={this.handleUserClick.bind(this, this.props.userNames[x])}> | ||
| {this.props.userNames[x].first_name} | ||
| {this.props.userNames[x].last_name} | ||
| {this.props.userNames[x].id}</p> |
There was a problem hiding this comment.
Closing p tag should be on the same indentation level as opening tag.
| );// end of return; | ||
| }) // end of map function | ||
| } // end of display usernames | ||
| <UserDetail num={this.props.userNames} /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first commit