Skip to content

Update README regarding eslint Windows caveat #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zacacollier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README regarding eslint Windows caveat #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,20 @@
### Setup
* From address book directory, run yarn install, yarn start


##### A note for Windows users about line-endings
- If you're getting errors like this:

```bash
(linebreak-style) Expected linebreaks to be 'LF' but found 'CRLF'. (eslint)
```
You can fix this by changing how Atom parses line endings in your code. (Meaning how it knows where you hit `Enter`).
By default, you should have [this plugin](https://github.com/atom/line-ending-selector) installed, which will allow you to change your line-ending encoding:

**1. Click on this section in the bottom-right of your screen.**
![](https://cloud.githubusercontent.com/assets/1305617/9274149/6b317568-4293-11e5-83ba-614a6c0d9890.png)
**2. Then just select `LF`. The errors should go away.**
![](https://cloud.githubusercontent.com/assets/1305617/9273907/2be5c136-4291-11e5-94af-65ece408eb12.png)
### Do
* Import the array of users into index.js
* Create a folder in src called components to hold all our components
Expand Down