alex.garcia.atx.advanced1 #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Created 7 components -Created UserDetail and ListofUsers -Imported them and used components in App
Need to organize components within page.
Address Book in Alphabetical Order!
Still need to fix state: visible.
ivome
reviewed
May 1, 2017
| @@ -0,0 +1,27 @@ | |||
| import React from "react"; | |||
| import "./App.css"; | |||
| import users from "../users"; | |||
There was a problem hiding this comment.
Better import the users in the index.js and then pass them down as props. That way this component would be reusable... Right now you have a hard dependency in there.
| ); | ||
| } | ||
|
|
||
| function printUsers(user) { |
There was a problem hiding this comment.
Naming: In react, the users are not really printed... render would probably be more accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.