fix: oauth popup profile picture renders as a perfect circle#14280
Merged
raymondjacobson merged 1 commit intomainfrom May 8, 2026
Merged
fix: oauth popup profile picture renders as a perfect circle#14280raymondjacobson merged 1 commit intomainfrom
raymondjacobson merged 1 commit intomainfrom
Conversation
The harmony Image migration in #14196 wraps the avatar in a Box that respects h/w props (78px). The OAuth page only overrode height to 48px, leaving width at 78px and rendering a 78×48 pill instead of a circle. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14280.audius.workers.dev Unique preview for this PR (deployed from this branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Imagemigration in Consolidate images and improve loading #14196 swappedProfileInfo's plain<img>for<Image>, which wraps the avatar in aBoxthat respectsh/wprops (78px)..profileImgonly overrodeheight: 48px, leaving the wrapper at 78px wide and rendering a 78×48 pill shape instead of a circle.width: 48pxso the wrapper is square and the existingborder-radiusproduces a perfect circle.Test plan
🤖 Generated with Claude Code