Update feed created_at to include release_date#692
Open
dylanjeffers wants to merge 1 commit intomainfrom
Open
Conversation
| 'track' as entity_type, | ||
| track_id as entity_id, | ||
| created_at | ||
| GREATEST(tracks.created_at, COALESCE(tracks.release_date, tracks.created_at)) as created_at |
Member
There was a problem hiding this comment.
I think this will break our cache on the client because we will have different values for created_at across the same track
| AND created_at < @before | ||
| AND created_at >= @before::timestamp - INTERVAL '1 YEAR' | ||
| AND GREATEST(tracks.created_at, COALESCE(tracks.release_date, tracks.created_at)) < @before | ||
| AND GREATEST(tracks.created_at, COALESCE(tracks.release_date, tracks.created_at)) >= @before::timestamp - INTERVAL '1 YEAR' |
Member
There was a problem hiding this comment.
concerned abt query performance, can you play with the query planning for an account like mine?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.