Update usages of Cfg to use app.config and use static senders for rewards #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyrombo
commented
Dec 2, 2025
|
|
||
| func TestRecordBalanceHistoryConflictHandling(t *testing.T) { | ||
| pool := database.CreateTestDatabase(t, "test_api") | ||
| pool := database.CreateTestDatabase(t, "test_jobs") |
Contributor
Author
There was a problem hiding this comment.
fyi @dylanjeffers sorry I didn't catch this in initial review - each "package" of tests in go runs in parallel, and only one database can be created from a template at a time, so each package has its own template to use for tests to avoid race conditions
super annoying footgun but it makes tests faasstt
raymondjacobson
approved these changes
Dec 2, 2025
| // Disable message push by default. Tests for it can create | ||
| // an RPC processor directly. | ||
| CommsMessagePush: false, | ||
| ChainId: "audius-devnet", |
Member
There was a problem hiding this comment.
what's this change from?
Contributor
Author
There was a problem hiding this comment.
we depend on this being devnet for the block_confirmation tests. I didn't realize we had a whole separate config we started here for tests :P
rickyrombo
commented
Dec 2, 2025
| solanaPubKey := solana.PublicKeyFromBytes(testPublicKey) | ||
| testPubKeyBase58 := solanaPubKey.String() | ||
| config.Cfg.RewardCodeAuthorizedKeys = []string{testPubKeyBase58} | ||
| app.config.RewardCodeAuthorizedKeys = []string{testPubKeyBase58} |
Contributor
Author
There was a problem hiding this comment.
we should really just stick these into the test config, but leaving as-is for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.