Skip to content

Conversation

@river0525
Copy link
Collaborator

@river0525 river0525 commented Dec 28, 2025

テーブル名を「予選」から「予選(旧形式)」に変更しました。

ご確認よろしくお願いいたします。

Summary by CodeRabbit

  • New Features
    • Updated contest category and button labels to explicitly mark the JOI qualification rounds as the "old format" (improves clarity when browsing competitions).
  • Tests
    • Updated expectations to match the new "old format" label so UI/test outputs remain consistent.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2025

Walkthrough

Update display strings to mark JOI qualification rounds as the "old format" by appending "(旧形式)" to metadata title and related group labels; corresponding test expectations were adjusted.

Changes

Cohort / File(s) Summary
Contest provider source
src/lib/utils/contest_table_provider.ts
JOIQualRoundFrom2006To2019Provider.getMetadata() title changed from 'JOI 予選' to 'JOI 予選(旧形式)'; JOISecondQualAndSemiFinalRound group groupName and buttonLabel updated to include '(旧形式)'.
Tests
src/test/lib/utils/contest_table_provider.test.ts
Updated test expectation for the provider metadata title from "JOI 予選" to "JOI 予選(旧形式)".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through code with careful feet,
Tagged old JOI rounds so labels meet,
"(旧形式)" now sits in place,
A vintage mark with gentle grace,
Small change — a tidy, happy treat! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: renaming qualification round table labels from old to new format notation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rename_qual_round

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 046cc70 and d0cb047.

📒 Files selected for processing (1)
  • src/test/lib/utils/contest_table_provider.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: preview
🔇 Additional comments (1)
src/test/lib/utils/contest_table_provider.test.ts (1)

2326-2326: LGTM! Test expectation correctly updated.

The test now expects the metadata title to be 'JOI 予選(旧形式)', which correctly reflects the table name change from "予選" (Qualification Round) to "予選(旧形式)" (Qualification Round - Old Format).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KATO-Hiro KATO-Hiro changed the title close #3001 rename_qual_round_table chore: rename_qual_round_table Dec 28, 2025
@KATO-Hiro KATO-Hiro changed the title chore: rename_qual_round_table chore: Rename_qual_round_table Dec 28, 2025
@KATO-Hiro KATO-Hiro changed the title chore: Rename_qual_round_table chore: Rename qual round table Dec 28, 2025
Copy link
Collaborator

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@river0525
テーブルのラベルの修正をしていただき、ありがとうございます

単体テストが1つ更新されておらず、失敗しているようです

お手数ですが、以下のテストを修正していただけますでしょうか?
src/test/lib/utils/contest_table_provider.test.ts > ContestTableProviderBase and implementations > JOI Qual Round From 2006 To 2019 provider > expects to get correct metadata

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/test/lib/utils/contest_table_provider.test.ts (1)

2638-2740: Add test coverage for JOISecondQualAndSemiFinalRound preset.

The JOISecondQualAndSemiFinalRound preset exists in the source code with groupName and buttonLabel values of "JOI 二次予選・予選(旧形式)・本選", but it lacks a corresponding test case in the prepareContestProviderPresets describe block. Add a test to verify this preset creates the correct group with expected metadata and provider instance.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 046cc70 and d0cb047.

📒 Files selected for processing (1)
  • src/test/lib/utils/contest_table_provider.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: preview
🔇 Additional comments (1)
src/test/lib/utils/contest_table_provider.test.ts (1)

2326-2326: LGTM! Test expectation correctly updated.

The test now expects the metadata title to be 'JOI 予選(旧形式)', which correctly reflects the table name change from "予選" (Qualification Round) to "予選(旧形式)" (Qualification Round - Old Format).

@river0525
Copy link
Collaborator Author

river0525 commented Dec 28, 2025

@KATO-Hiro
大変失礼いたしました。
単体テストの修正を行いましたので、ご確認よろしくお願いいたします。

Copy link
Collaborator

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます

確認しました
マージします

@KATO-Hiro KATO-Hiro merged commit 87f4600 into staging Dec 28, 2025
3 checks passed
@KATO-Hiro KATO-Hiro deleted the rename_qual_round branch December 28, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants