-
-
Notifications
You must be signed in to change notification settings - Fork 10
chore: Rename qual round table #3002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdate display strings to mark JOI qualification rounds as the "old format" by appending "(旧形式)" to metadata title and related group labels; corresponding test expectations were adjusted. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@river0525
テーブルのラベルの修正をしていただき、ありがとうございます
単体テストが1つ更新されておらず、失敗しているようです
お手数ですが、以下のテストを修正していただけますでしょうか?
src/test/lib/utils/contest_table_provider.test.ts > ContestTableProviderBase and implementations > JOI Qual Round From 2006 To 2019 provider > expects to get correct metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/test/lib/utils/contest_table_provider.test.ts (1)
2638-2740: Add test coverage for JOISecondQualAndSemiFinalRound preset.The
JOISecondQualAndSemiFinalRoundpreset exists in the source code withgroupNameandbuttonLabelvalues of "JOI 二次予選・予選(旧形式)・本選", but it lacks a corresponding test case in theprepareContestProviderPresetsdescribe block. Add a test to verify this preset creates the correct group with expected metadata and provider instance.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
src/test/lib/utils/contest_table_provider.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: preview
🔇 Additional comments (1)
src/test/lib/utils/contest_table_provider.test.ts (1)
2326-2326: LGTM! Test expectation correctly updated.The test now expects the metadata title to be
'JOI 予選(旧形式)', which correctly reflects the table name change from "予選" (Qualification Round) to "予選(旧形式)" (Qualification Round - Old Format).
|
@KATO-Hiro |
KATO-Hiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正ありがとうございます
確認しました
マージします
テーブル名を「予選」から「予選(旧形式)」に変更しました。
ご確認よろしくお願いいたします。
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.