Skip to content

Conversation

@KATO-Hiro
Copy link
Collaborator

@KATO-Hiro KATO-Hiro commented Dec 21, 2025

close #2986

Summary by CodeRabbit

  • New Features

    • Extended contest recognition system to support NIKKEI2019 QUAL contests. The system now properly identifies and classifies this contest format, improving compatibility with additional contest sources.
  • Tests

    • Added test cases to verify correct classification of NIKKEI2019 QUAL contests and ensure proper functionality of the expanded recognition system.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 21, 2025

Walkthrough

Added support for 'nikkei2019-qual' contest classification as ARC_LIKE by extending the ARC_LIKE prefix mapping with a new entry, alongside a corresponding test case verifying the classification behavior.

Changes

Cohort / File(s) Summary
ARC_LIKE Contest Support
src/lib/utils/contest.ts
Added 'nikkei2019-qual' entry to ARC_LIKE constant mapping it to '全国統一プログラミング王決定戦予選'; updated comment date reference
Test Coverage
src/test/lib/utils/test_cases/contest_type.ts
Added test case verifying 'nikkei2019-qual' is correctly classified as ContestType.ARC_LIKE

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Verify the contest ID 'nikkei2019-qual' and its Japanese label are correctly mapped
  • Confirm the test case appropriately validates the new classification

Poem

🐰 A new contest joins the fold,

Nikkei's trials, brave and bold!

ARC-like now, mapped with care,

Tests ensure it's recognized fair. ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: Add tasks for ARC-like' accurately describes the main change: adding a new ARC-like contest entry (nikkei2019-qual) to the contest classification system.
Linked Issues check ✅ Passed The PR successfully adds support for the nikkei2019-qual contest as an ARC-like contest with corresponding test case, fulfilling the requirement to enable problem import from issue #2986.
Out of Scope Changes check ✅ Passed All changes are directly related to the objective of adding ARC-like contest support; no extraneous modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch #2986

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 6adb23d and 6ad4821.

📒 Files selected for processing (2)
  • src/lib/utils/contest.ts (2 hunks)
  • src/test/lib/utils/test_cases/contest_type.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/test/lib/utils/test_cases/contest_type.ts (1)
src/lib/types/contest.ts (2)
  • ContestType (30-53)
  • ContestType (56-56)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: preview
🔇 Additional comments (2)
src/test/lib/utils/test_cases/contest_type.ts (1)

292-295: LGTM!

The test case follows the established pattern and correctly verifies the new nikkei2019-qual contest is classified as ARC_LIKE.

src/lib/utils/contest.ts (1)

99-99: LGTM!

The new nikkei2019-qual entry is correctly added to the ARC_LIKE mapping with the appropriate Japanese contest name. The HACK comment date update reflects the current state of the configuration.

Also applies to: 129-129


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator Author

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit 97bf516 into staging Dec 21, 2025
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #2986 branch December 21, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

問題をインポートできるようにしましょう

2 participants