-
-
Notifications
You must be signed in to change notification settings - Fork 10
fix: Use pnpm exec instead of pnpm dlx (#2960) #2961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughSwitch Prisma seed execution from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (1)
🧰 Additional context used🪛 LanguageTooldocs/dev-notes/2025-12-17/use_pnpm_exec/plan.md[grammar] ~11-~11: Ensure spelling is correct (QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1) 🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/dev-notes/2025-12-17/use_pnpm_exec/plan.md (1)
33-33: Optional: Address markdown linting suggestions.Minor markdown formatting improvements flagged by static analysis:
- Line 33: Add a language identifier to the fenced code block (e.g.,
text` orshell`)- Lines 137-141: Convert bare URLs to markdown link syntax for consistency
Example for lines 137-141:
-- vite-node: https://github.com/vitest-dev/vitest +- vite-node: [https://github.com/vitest-dev/vitest](https://github.com/vitest-dev/vitest)These are purely stylistic and don't affect the documentation's clarity.
Also applies to: 137-141
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
docs/dev-notes/2025-12-17/use_pnpm_exec/plan.md(1 hunks)package.json(2 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/dev-notes/2025-12-17/use_pnpm_exec/plan.md
[grammar] ~11-~11: Ensure spelling is correct
Context: ...new projects, please consider using the builtin Vite one instead." 出典: [vite-node ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.18.1)
docs/dev-notes/2025-12-17/use_pnpm_exec/plan.md
33-33: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
137-137: Bare URL used
(MD034, no-bare-urls)
138-138: Bare URL used
(MD034, no-bare-urls)
139-139: Bare URL used
(MD034, no-bare-urls)
140-140: Bare URL used
(MD034, no-bare-urls)
141-141: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: preview
🔇 Additional comments (3)
package.json (2)
27-28: LGTM! Script changes align with PR objective.The switch from
pnpm dlxtopnpm execensures these scripts use the versions specified in package.json rather than fetching the latest from the registry each time, improving consistency and speed.
68-68: Version 4.21.0 is valid and has no known security vulnerabilities.tsx version 4.21.0 is the latest version, published 16 days ago, and has no known vulnerabilities. The explicit devDependency declaration is appropriate for version control.
docs/dev-notes/2025-12-17/use_pnpm_exec/plan.md (1)
1-141: Excellent documentation quality.The documentation thoroughly explains the rationale for switching from
vite-nodetotsx, including:
- Historical context about vite-node deprecation
- Comparison of alternatives (Node.js built-in vs tsx)
- Clear Q&A addressing the differences between
pnpm dlxandpnpm exec- Implementation details with code examples
This will help future maintainers understand the decision and context.
KATO-Hiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #2960
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.