Skip to content

Conversation

@KATO-Hiro
Copy link
Collaborator

@KATO-Hiro KATO-Hiro commented Nov 27, 2025

close #2889

Summary by CodeRabbit

  • Chores
    • Enhanced contest metadata display to include problem counts for each AtCoder Beginner Contest tier, providing clearer information about contest formats.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2025

Walkthrough

Updated metadata titles for three AtCoder Beginner Contest provider definitions to include explicit per-contest problem counts (7, 8, and 6 problems respectively). Corresponding test expectations were updated to match the new title formats.

Changes

Cohort / File(s) Change Summary
Contest metadata titles
src/lib/utils/contest_table_provider.ts
Updated three provider metadata titles to include problem count suffixes: ABC319Onwards now ends with "(7 問制)", ABC212ToABC318 includes "(8 問制)", and ABC126ToABC211 includes "(6 問制)".
Test expectations
src/test/lib/utils/contest_table_provider.test.ts
Updated three test assertions to expect the new metadata titles with problem count information appended to each contest range.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Changes are purely metadata string updates with no logic modifications
  • Test updates directly mirror the implementation changes in a consistent pattern
  • Straightforward verification of title format alignment across both files

Poem

🐰 Hop hop, problem counts now glow,
Seven, eight, and six in a row,
Labels dressed in Japanese flair,
Contest tables beyond compare!

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: Update labels in table' is somewhat generic but directly relates to the main change of updating ABC provider labels in the table.
Linked Issues check ✅ Passed All three label updates specified in issue #2889 (ABC319, ABC212-318, ABC126-211) are correctly implemented with the required 問数 counts.
Out of Scope Changes check ✅ Passed All changes are scoped to updating the three ABC provider labels as specified in issue #2889; no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch #2889

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 32f7cbf and 05cfb64.

📒 Files selected for processing (2)
  • src/lib/utils/contest_table_provider.ts (3 hunks)
  • src/test/lib/utils/contest_table_provider.test.ts (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: preview
🔇 Additional comments (4)
src/lib/utils/contest_table_provider.ts (3)

185-190: LGTM! Clear metadata update.

The addition of (7 問制)makes the problem count explicit in the UI, which aligns with the PR objective to share terminology between practice goals and operators/users. The count correctly matches the comment on line 172.


215-220: LGTM! Consistent formatting.

The addition of (8 問制)maintains consistency with the ABC319Onwards provider and correctly reflects the "8 tasks per contest" documented in the comment on line 199.


245-250: LGTM! Completes the consistent pattern.

The addition of (6 問制)completes the update across all three ABC provider ranges, with the count correctly matching the "6 tasks per contest" documented in the comment on line 229.

src/test/lib/utils/contest_table_provider.test.ts (1)

267-267: LGTM! Test expectations correctly updated.

All three test expectations have been properly updated to match the new metadata titles in the provider implementations. The tests now correctly validate that the problem counts are included in the titles:

  • ABC319Onwards: (7 問制)
  • ABC212ToABC318: (8 問制)
  • ABC126ToABC211: (6 問制)

Also applies to: 310-310, 354-354

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator Author

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit b8bce94 into staging Nov 27, 2025
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #2889 branch November 27, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI/UX] ABCのテーブルのラベルを修正しましょう

2 participants