Skip to content

fix: rebuild database when custom file filters are provided #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MuLeiSY2021 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: rebuild database when custom file filters are provided #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 32 additions & 25 deletions api/data_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,34 +865,41 @@ def _embedding_vector_length(doc: Document) -> int:
# Handle backward compatibility
if embedder_type is None and is_ollama_embedder is not None:
embedder_type = 'ollama' if is_ollama_embedder else None
# Check if custom file filters are provided
has_custom_filters = any([excluded_dirs, excluded_files, included_dirs, included_files])

# check the database
if self.repo_paths and os.path.exists(self.repo_paths["save_db_file"]):
logger.info("Loading existing database...")
try:
self.db = LocalDB.load_state(self.repo_paths["save_db_file"])
documents = self.db.get_transformed_data(key="split_and_embed")
if documents:
lengths = [_embedding_vector_length(doc) for doc in documents]
non_empty = sum(1 for n in lengths if n > 0)
empty = len(lengths) - non_empty
sample_sizes = sorted({n for n in lengths if n > 0})[:3]
logger.info(
"Loaded %s documents from existing database (embeddings: %s non-empty, %s empty; sample_dims=%s)",
len(documents),
non_empty,
empty,
sample_sizes,
)

if non_empty == 0:
logger.warning(
"Existing database contains no usable embeddings. Rebuilding embeddings..."
if has_custom_filters:
logger.info("Custom file filters provided. Rebuilding database to apply filters...")
os.remove(self.repo_paths["save_db_file"])
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The os.remove() call is not wrapped in a try-except block, which could lead to unhandled exceptions (e.g., PermissionError) and cause the request to fail. It's best practice to handle potential file system errors to make the application more robust.

Suggested change
os.remove(self.repo_paths["save_db_file"])
try:
os.remove(self.repo_paths["save_db_file"])
except OSError as e:
logger.warning(f"Could not remove cached database file: {e}. Proceeding to rebuild.")

else:
logger.info("Loading existing database...")
try:
self.db = LocalDB.load_state(self.repo_paths["save_db_file"])
documents = self.db.get_transformed_data(key="split_and_embed")
if documents:
lengths = [_embedding_vector_length(doc) for doc in documents]
non_empty = sum(1 for n in lengths if n > 0)
empty = len(lengths) - non_empty
sample_sizes = sorted({n for n in lengths if n > 0})[:3]
logger.info(
"Loaded %s documents from existing database (embeddings: %s non-empty, %s empty; sample_dims=%s)",
len(documents),
non_empty,
empty,
sample_sizes,
)
else:
return documents
except Exception as e:
logger.error(f"Error loading existing database: {e}")
# Continue to create a new database

if non_empty == 0:
logger.warning(
"Existing database contains no usable embeddings. Rebuilding embeddings..."
)
else:
return documents
except Exception as e:
logger.error(f"Error loading existing database: {e}")
# Continue to create a new database

# prepare the database
logger.info("Creating new database...")
Expand Down