Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the system's flexibility by integrating OpenRouter as a new embedding provider. This allows users to access a broader spectrum of embedding models, leveraging OpenRouter's unified API for diverse AI capabilities. The changes include core configuration updates and extensive documentation to ensure a smooth setup and usage experience for this new option. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for OpenRouter as an embedding provider, which is a great addition. The changes include updating documentation in README.md and api/README.md, adding configuration in api/config/embedder.json, and updating the logic in api/config.py and api/tools/embedder.py to handle the new embedder type.
The changes are well-implemented. I have one suggestion for api/config.py to improve the consistency and robustness of the new is_openrouter_embedder function by making it inspect the configuration object, similar to the other embedder-checking functions. This will make the code more maintainable in the long run.
Solves #490