-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix: correct Ollama installation using tar.zst format #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add zstd package required to decompress .tar.zst files - Change download URL from .tgz to .tar.zst (correct Ollama format) - Update tar command to use --zstd flag instead of -z
… image size for ollama image
Summary of ChangesHello @Mickyleitor, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Ollama installation process within the Dockerfile by addressing an outdated download format. It ensures that Ollama is successfully installed by incorporating support for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes the Ollama installation in the Dockerfile by switching to the .tar.zst format. The changes, including adding the zstd package and updating the download and extraction commands, are appropriate. I've added a couple of suggestions to further optimize the Dockerfile by applying common best practices, such as using --no-install-recommends during package installation and piping curl output directly to tar. These changes will help reduce the final image size and improve the build process's efficiency.
| RUN apt-get update && apt-get install -y \ | ||
| curl | ||
| curl \ | ||
| zstd && \ | ||
| rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To optimize the Docker image size and follow best practices, it's recommended to use the --no-install-recommends flag with apt-get install. This prevents the installation of packages that are not strictly necessary for the main packages to function.
RUN apt-get update && apt-get install -y --no-install-recommends \
curl \
zstd && \
rm -rf /var/lib/apt/lists/*
| curl -L "https://ollama.com/download/ollama-linux-${OLLAMA_ARCH}.tar.zst" -o ollama.tar.zst && \ | ||
| tar --zstd -xf ollama.tar.zst -C /usr && \ | ||
| rm ollama.tar.zst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve efficiency and avoid creating an intermediate file on the filesystem, you can pipe the output of curl directly into tar. This makes the command cleaner and avoids the need for a separate rm step.
curl -L "https://ollama.com/download/ollama-linux-${OLLAMA_ARCH}.tar.zst" | tar --zstd -x -C /usr
This MR will change the following regarding the Ollama Dockerfile: