Fix: Compatibility with urllib3 v2.0+ and Python 3.11+#125
Open
arielsaghiv wants to merge 2 commits into
Open
Conversation
crash on latest octoprint 1.11.7 - Update setup.py dependencies for urllib3 v2
Handle ImportError for requests_toolbelt and adjust import statement. Add fallback for requests-toolbelt import error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current version hard-locks
urllib3 < 2.0.0. On modern systems (Python 3.11+),urllib3v2.0 removedurllib3.contrib.appengine, causing a hardImportErrorwhenrequests-toolbeltis initialized.Solution
setup.pyto allowrequests-toolbelt >= 1.0.0andurllib3up tov3.try/exceptblock inAstroprintCloud.pyto handle theImportErrorgracefully on modern stacks.Verification
Verified working on OctoPrint 1.11.7 running Python 3.11.2 and urllib3 2.7.0.