Skip to content

fix: use UMO-bound config for group_icl_enable in on_message #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saschabuehrle wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

fix: use UMO-bound config for group_icl_enable in on_message #7397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions astrbot/builtin_stars/astrbot/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ async def on_message(self, event: AstrMessageEvent):
if self.ltm_enabled(event) and self.ltm and has_image_or_plain:
need_active = await self.ltm.need_active_reply(event)

group_icl_enable = self.context.get_config()["provider_ltm_settings"][
"group_icl_enable"
]
group_icl_enable = self.context.get_config(
umo=event.unified_msg_origin
)["provider_ltm_settings"]["group_icl_enable"]
Comment on lines +39 to +41
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The configuration for the current UMO is fetched multiple times in this method (via ltm_enabled, need_active_reply, and again here). While this PR correctly fixes the UMO binding, consider fetching the configuration once at the beginning of on_message and reusing it to avoid redundant lookups and improve efficiency.

if group_icl_enable:
"""记录对话"""
try:
Expand Down