breaking: Update dependencies (binaryen v125)

NOTICE

@@ -62,6 +62,7 @@ under the licensing terms detailed in LICENSE:
 * Kam Chehresa <kaz.che@gmail.com>
 * Mopsgamer <79159094+Mopsgamer@users.noreply.github.com>
 * EDM115 <github@edm115.dev>
+* Anakun <anakun@opnet.org>
 
 Portions of this software are derived from third-party works licensed under
 the following terms:

cli/index.js

@@ -425,7 +425,7 @@ export async function main(argv, options) {
         } catch (e1) {
           try {
             transform = require(resolved);
-          } catch (e2) {
+          } catch {
             return prepareResult(e1);
           }
         }
@@ -1024,7 +1024,7 @@ export async function main(argv, options) {
     try {
       stats.readCount++;
       return await fs.promises.readFile(name, "utf8");
-    } catch (e) {
+    } catch {
       return null;
     }
   }
@@ -1038,7 +1038,7 @@ export async function main(argv, options) {
       await fs.promises.mkdir(dirPath, { recursive: true });
       await fs.promises.writeFile(filePath, contents);
       return true;
-    } catch (e) {
+    } catch {
       return false;
     }
   }
@@ -1049,7 +1049,7 @@ export async function main(argv, options) {
       stats.readCount++;
       return (await fs.promises.readdir(path.join(baseDir, dirname)))
         .filter(file => extension_re_except_d.test(file));
-    } catch (e) {
+    } catch {
       return null;
     }
   }
@@ -1105,7 +1105,7 @@ async function getConfig(file, baseDir, readFile) {
   let config;
   try {
     config = JSON.parse(contents);
-  } catch(ex) {
+  } catch {
     throw new Error(`Asconfig is not valid json: ${location}`);
   }
 

eslint.config.js

@@ -0,0 +1,328 @@
+import eslint from "@eslint/js";
+import tseslint from "typescript-eslint";
+import globals from "globals";
+
+export default tseslint.config(
+  {
+    ignores: [
+      "node_modules/**",
+      "dist/**",
+      "build/**",
+      "out/**",
+      ".github/**",
+      "tests/parser/**"
+    ]
+  },
+
+  eslint.configs.recommended,
+
+  // === General rules =========================================================
+
+  {
+    languageOptions: {
+      ecmaVersion: "latest",
+      sourceType: "module",
+      globals: {
+        "globalThis": "readonly",
+        "BigInt64Array": "readonly",
+        "BigUint64Array": "readonly",
+        "WebAssembly": "readonly",
+        "FinalizationRegistry": "readonly",
+        "fetch": "readonly",
+        "URL": "readonly",
+        "console": "readonly"
+      }
+    },
+    rules: {
+      // Omitted semicolons are hugely popular, yet within the compiler it makes
+      // sense to be better safe than sorry.
+      "semi": "error",
+
+      // Our code bases uses 2 spaces for indentation, and we enforce it here so
+      // files don't mix spaces, tabs or different indentation levels.
+      "indent": ["error", 2, {
+        "SwitchCase": 1,
+        "VariableDeclarator": "first",
+        "offsetTernaryExpressions": true,
+        "ignoredNodes": [ // FIXME: something's odd here
+          "ConditionalExpression > *",
+          "ConditionalExpression > * > *",
+          "ConditionalExpression > * > * > *"
+        ]
+      }],
+
+      // This is mostly visual style, making comments look uniform.
+      "spaced-comment": ["error", "always", {
+        "markers": ["/"],   // triple-slash
+        "exceptions": ["/"] // all slashes
+      }],
+
+      // This tends to be annoying as it encourages developers to make everything
+      // that is never reassigned a 'const', sometimes semantically incorrect so,
+      // typically leading to huge diffs in follow-up PRs modifying affected code.
+      "prefer-const": "off",
+
+      // It is perfectly fine to declare top-level variables with `var`, yet this
+      // rule doesn't provide configuration options that would help.
+      "no-var": "off",
+
+      // Quite often, dealing with multiple related cases at once or otherwise
+      // falling through is exactly the point of using a switch.
+      "no-fallthrough": "off",
+
+      // Typical false-positives here are `do { ... } while (true)` statements or
+      // similar, but the only option provided here is not checking any loops.
+      "no-constant-condition": ["error", { checkLoops: false }],
+
+      // Functions are nested in blocks occasionally, and there haven't been any
+      // problems with this so far, so turning the check off.
+      "no-inner-declarations": "off",
+
+      // Disabled here, but enabled again for JavaScript files.
+      "no-unused-vars": "off",
+    }
+  },
+
+  // === JavaScript rules ====================================================
+
+  {
+    files: [
+      "**/*.js",
+      "bin/*"
+    ],
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.amd,
+        ...globals.node,
+        ...globals.es6
+      }
+    },
+    rules: {
+      // Enforcing to remove function parameters on stubs makes code less
+      // maintainable, so we instead allow unused function parameters.
+      "no-unused-vars": [
+        "warn", {
+          "vars": "local",
+          "args": "none",
+          "ignoreRestSiblings": false
+        }
+      ],
+
+      "no-loss-of-precision": "error",
+    }
+  },
+
+  // === TypeScript rules ====================================================
+
+  {
+    files: [
+      "**/*.ts"
+    ],
+    languageOptions: {
+      parser: tseslint.parser,
+      parserOptions: {
+        ecmaVersion: "latest",
+        sourceType: "module",
+        experimentalDecorators: true,
+        allowInvalidAST: true,
+        ecmaFeatures: {}
+      }
+    },
+    plugins: {
+      "@typescript-eslint": tseslint.plugin
+    },
+    rules: {
+      // Quite common in scenarios where an iteration starts at `current = this`.
+      "@typescript-eslint/no-this-alias": "off",
+
+      // Interferes with tests and 64-bit literals
+      "@typescript-eslint/no-loss-of-precision": "off",
+      "no-loss-of-precision": "off",
+
+      // TypeScript handles this
+      "no-redeclare": "off",
+
+      // Disabled here, but enabled again for TypeScript files.
+      "@typescript-eslint/no-unused-vars": "off",
+
+      // We use require in some places
+      "@typescript-eslint/no-require-imports": "off",
+
+      // Allow unused expressions (used in some code patterns)
+      "@typescript-eslint/no-unused-expressions": "off",
+
+      // Empty object types are used in definitions
+      "@typescript-eslint/no-empty-object-type": "off"
+    }
+  },
+
+  {
+    files: [
+      "**/*.ts"
+    ],
+    rules: {
+      // Enforcing to remove function parameters on stubs makes code less
+      // maintainable, so we instead allow unused function parameters.
+      "@typescript-eslint/no-unused-vars": [
+        "warn", {
+          "vars": "local",
+          "varsIgnorePattern": "^[A-Z](?:From|To)?$", // ignore type params
+          "args": "none",
+          "ignoreRestSiblings": false
+        }
+      ]
+    }
+  },
+
+  // === AssemblyScript rules (extends TypeScript rules) =====================
+
+  {
+    files: [
+      "**/assembly/**/*.ts",
+      "src/**/*.ts",
+      "lib/parse/src/**/*.ts"
+    ],
+    rules: {
+      // AssemblyScript has its own globals
+      "no-undef": "off",
+
+      // Namespaces are quite useful in AssemblyScript
+      "@typescript-eslint/no-namespace": "off",
+
+      // There is actually codegen difference here
+      "@typescript-eslint/no-array-constructor": "off",
+
+      // Sometimes it can't be avoided to add a @ts-ignore
+      "@typescript-eslint/ban-ts-comment": "off",
+
+      // Utilized to achieve portability in some cases
+      "@typescript-eslint/no-non-null-assertion": "off",
+    }
+  },
+
+  // === Compiler rules (extends AssemblyScript rules) =======================
+
+  {
+    files: [
+      "src/**/*.ts",
+      "std/assembly/**/*.ts"
+    ],
+    rules: {
+      // There is an actual codegen difference here - TODO: revisit
+      "no-cond-assign": "off",
+
+      // Not all types can be omitted in AS yet - TODO: revisit
+      "@typescript-eslint/no-inferrable-types": "off",
+
+      // Used rarely to reference internals that are not user-visible
+      "@typescript-eslint/triple-slash-reference": "off",
+
+      // The compiler has its own `Function` class for example
+      "no-shadow-restricted-names": "off",
+      "@typescript-eslint/ban-types": "off"
+    }
+  },
+
+  // === Standard Library rules (extends AssemblyScript rules) ===============
+
+  {
+    files: [
+      "std/assembly/**/*.ts"
+    ],
+    rules: {
+      // We are implementing with --noLib, so we shadow all the time
+      "no-shadow-restricted-names": "off",
+
+      // Similarly, sometimes we need the return type to be String, not string
+      "@typescript-eslint/ban-types": "off"
+    }
+  },
+
+  // === Standard Definition rules (extends TypeScript rules) ================
+
+  {
+    files: [
+      "std/**/*.d.ts"
+    ],
+    rules: {
+      // Definition files have their own globals
+      "no-undef": "off",
+
+      // Often required to achieve compatibility with TypeScript
+      "@typescript-eslint/no-explicit-any": "off",
+
+      // Interfaces can be stubs here, i.e. not yet fully implemented
+      "@typescript-eslint/no-empty-object-type": "off",
+
+      // Definitions make use of `object` to model rather unusual constraints
+      "@typescript-eslint/ban-types": "off"
+    }
+  },
+
+  // === Compiler Definition rules (extends TypeScript rules) ================
+
+  {
+    files: [
+      "./dist/*.d.ts"
+    ],
+    rules: {
+      // Our definitions are complicated, and all attempts to describe them
+      // as modules have failed so far. As such, we re-export namespaces.
+      "@typescript-eslint/no-namespace": "off",
+      "@typescript-eslint/triple-slash-reference": "off"
+    }
+  },
+
+  // === Other Definition rules ==============================================
+
+  {
+    files: [
+      "**/*.d.ts"
+    ],
+    rules: {
+      // Definition files have their own globals
+      "no-undef": "off"
+    }
+  },
+
+  // === Test rules (extends TypeScript rules) ===============================
+
+  {
+    files: [
+      "./tests/compiler/**/*.ts",
+      "./lib/loader/tests/assembly/**/*.ts"
+    ],
+    rules: {
+      // Test files have their own globals
+      "no-undef": "off",
+
+      // Tests typically include unusual code patterns on purpose. This is
+      // very likely not an extensive list, but covers what's there so far.
+      "no-empty": "off",
+      "no-cond-assign": "off",
+      "no-compare-neg-zero": "off",
+      "no-inner-declarations": "off",
+      "no-constant-condition": "off",
+      "no-constant-binary-expression": "off",
+      "no-const-assign": "off",
+      "no-this-before-super": "off",
+      "no-unreachable": "off",
+      "no-dupe-class-members": "off",
+      "no-dupe-args": "off",
+      "constructor-super": "off",
+      "use-isnan": "off",
+      "@typescript-eslint/no-namespace": "off",
+      "@typescript-eslint/no-unused-vars": "off",
+      "@typescript-eslint/no-empty-function": "off",
+      "@typescript-eslint/no-non-null-assertion": "off",
+      "@typescript-eslint/no-extra-semi": "off",
+      "@typescript-eslint/no-inferrable-types": "off",
+      "@typescript-eslint/ban-types": "off",
+      "@typescript-eslint/triple-slash-reference": "off",
+      "@typescript-eslint/ban-ts-comment": "off",
+      "@typescript-eslint/no-extra-non-null-assertion": "off",
+      "@typescript-eslint/no-empty-object-type": "off"
+    }
+  },
+);

lib/loader/tests/index.js

@@ -222,9 +222,9 @@ function test(file) {
   {
     let ptr = exports.__newString("test");
     exports.__pin(ptr);
-    try { exports.__pin(ptr); assert(false); } catch (e) { /* nop */ }
+    try { exports.__pin(ptr); assert(false); } catch { /* nop */ }
     exports.__unpin(ptr);
-    try { exports.__unpin(ptr); assert(false); } catch (e) { /* nop */ }
+    try { exports.__unpin(ptr); assert(false); } catch { /* nop */ }
   }
 
   // should be able to correctly call a function with variable arguments