External Link Handling Enhancement #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import shell module from Electron for external URL handling - Add setWindowOpenHandler to intercept new window creation attempts - Add will-navigate event handler to manage navigation within current window - External links (outside grok.com/x.com domains) now open in default browser - Internal Grok navigation continues to work normally within the app - Preserves login flow functionality for x.com/login URLs This improves user experience by keeping the app focused on Grok while allowing external content to open in the user's preferred browser. Tested successfully on Windows with both development and production builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves user experience by keeping the app focused on Grok while allowing external content to open in the user's preferred browser.
Tested successfully on Windows with both development and production builds.