Merged
Conversation
2 tasks
Signed-off-by: Arufonsu <17498701+Arufonsu@users.noreply.github.com>
Arufonsu
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug found after 0.8.0 beta-381 release.
This PR fixes #2771 - text input caret positioning issues in the Intersect client. It addresses problems where the cursor wouldn't update correctly when typing or editing text.
Key Changes
Label.cs - Refactors
OnChildBoundsChangedto ensure the control always invalidates when text bounds change. The logic is simplified by inverting conditions and explicitly callingInvalidate()at the end of the method, plus addingInvalidate()toOnTextExceedsSize.Text.cs - Improves
GetCharacterPositionto correctly calculate character positions whenMeasureTextfails. It adds the_scaleparameter to measurement calls and implements a fallback that manually calculates width for each character using a reference character ("n") when the renderer returns zero.These changes ensure the text caret displays at the correct position and updates properly on text input.