fix: add pub(super) visibility to tool_router and prompt_router macros#1
Open
decoded-brain wants to merge 1 commit into
Open
Conversation
The rmcp macros #[tool_router] and #[prompt_router] generate private associated functions by default. Since handler.rs accesses these generated functions from a sibling module (via Self::tool_router() and Self::prompt_router()), the compiler rejects the code with a visibility error. Adding vis = "pub(super)" to both macro invocations makes the generated functions visible within the parent module, fixing the compilation failure.
|
@decoded-brain is attempting to deploy a commit to the StriveX Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
#[tool_router]and#[prompt_router]macros fromrmcpgenerate private associated functions by default. Sincesrc/mcp/handler.rscalls these generated functions (Self::tool_router()andSelf::prompt_router()) from a sibling module, the Rust compiler rejects the code with a visibility error:This means
cargo install rust-doctorfails to compile.Fix
Added
vis = "pub(super)"to both macro invocations insrc/mcp/tools.rs:This makes the generated
tool_router()andprompt_router()functions visible within the parentmcpmodule, allowinghandler.rsto access them as intended.Testing
cargo buildafter this change.