Skip to content

Refine legend wording related to arm64 node compatibility #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nirmalsunny merged 2 commits into from
Jun 30, 2025
Merged

Refine legend wording related to arm64 node compatibility #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
312010d
Refine legend wording related to arm64 node compatibility
nirmalsunny Jun 25, 2025
95fde7a
newsfile
nirmalsunny Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ Output from a small cluster in EKS:

Legend:
-------
✅ - arm64 supported
🆙 - arm64 supported (with update)
❌ - arm64 not supported
✅ - arm64 node compatible
🆙 - arm64 node compatible (after update)
❌ - not arm64 node compatible
🚫 - error occurred
------------------------------------------------------------------------------------------------

Expand Down
1 change: 1 addition & 0 deletions changes/31.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Refine legend wording related to arm64 node compatibility
5 changes: 3 additions & 2 deletions cmd/images.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ const (
errorIcon = "\xF0\x9F\x9A\xAB"
failedIcon = "\xE2\x9D\x8C"
upgradeIcon = "\xF0\x9F\x86\x99"

legend = "Legend:\n-------\n%s - arm64 node compatible\n%s - arm64 node compatible (after update)\n%s - not arm64 node compatible\n%s - error occurred\n%s"
)

var (
Expand Down Expand Up @@ -71,7 +73,7 @@ func imagesCmdRun(_ *cobra.Command, _ []string) {
}

fmt.Printf(
"Legend:\n-------\n%s - arm64 supported\n%s - arm64 supported (with update)\n%s - arm64 not supported\n%s - error occurred\n%s",
legend,
successIcon,
upgradeIcon,
failedIcon,
Expand Down Expand Up @@ -132,7 +134,6 @@ func imagesCmdRun(_ *cobra.Command, _ []string) {
log.Println(res.icon, " image: ", res.image, " error: ", res.err, "\n", imageMap[res.image])
}
}

}

func init() {
Expand Down