Allow Chrome to support remote browser providers and one-chrome-per-snapshot mode#12
Merged
Allow Chrome to support remote browser providers and one-chrome-per-snapshot mode#12
Conversation
…g.js Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
…g.js Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds remote Chrome adoption via
CHROME_CDP_URLand an optional per‑snapshot isolation mode, with a CDP‑verified readiness contract and thin foreground wait barriers. Standardizes session markers and hook execution, centralizes CDP session setup, and strengthens teardown, stale‑session recovery, and CI logs.New Features
CHROME_CDP_URL(ws(s)/http(s)),CHROME_IS_LOCAL=falseto omitchrome.pid, optionalCHROME_KEEPALIVE=true.CHROME_ISOLATION=snapshotadds per‑snapshot lifecycle viaon_Snapshot__09_chrome_launch.daemon.bg.js; crawl mode remains default.connectToPagereturnsbrowser/page/cdpSessionand canwaitForNavigationCompletewithpostLoadDelayMs;waitForChromeSessionState(supportsrequireExtensionsLoaded);connectToBrowserEndpoint; auto‑attach; stronger stale‑session recovery; keepalive‑aware teardown;on_Crawl__91andon_Snapshot__11are thin foreground barriers.port.txt,final_url.txt,page_loaded.txt; usecdp_url.txtandnavigation.json.node/python); helper updated to execute scripts directly; downstream extractors (e.g., accessibility, dom, infiniscroll, consolelog, dns, headers, outlinks) now useconnectToPageandwaitForNavigationComplete.ABX_PYTEST_TEE_SUBPROCESS_OUTPUT=1), show full pytest results (-rA), expand Chrome tests for remote adoption and snapshot isolation.Migration
CHROME_CDP_URL,CHROME_IS_LOCAL=false, optionallyCHROME_KEEPALIVE=true.CHROME_ISOLATION=snapshot; snapshot launch hook starts/cleans the browser; crawl hooks skip launching.connectToPage/connectToBrowserEndpoint; usewaitForChromeSessionState;waitForPageLoadedis nowwaitForNavigationComplete.cdp_url.txtandnavigation.json.../base/utils.js.Written for commit 2d38e91. Summary will update on new commits.